From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Fam Zheng <famz@redhat.com>
Cc: "Benoît Canet" <benoit.canet@irqsave.net>,
kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: Make op blocker recursive
Date: Mon, 23 Jun 2014 07:17:31 +0200 [thread overview]
Message-ID: <20140623051731.GA21371@irqsave.net> (raw)
In-Reply-To: <20140623043230.GB5977@T430.nay.redhat.com>
The Monday 23 Jun 2014 à 12:32:30 (+0800), Fam Zheng wrote :
> On Sat, 06/21 17:40, Benoît Canet wrote:
> > The Saturday 21 Jun 2014 à 17:39:11 (+0200), Benoît Canet wrote :
> > > We still have the issue of unlocking the bottom BDS when a subtree is detached
> > > from the graphs by a swap. (It does happen in my drive-mirror arbitrary node
> > > replacement series).
> > >
> > > From my understanding the unlocking of the root BDS is done by drive_mirror_complete
> > > while the mirror code tries to unref the orphaned subtree _before_ drive_mirror_complete
> > > is called.
> >
> > One fixe to my sentence:
> > s/drive_mirror_complete/block_job_complete/
> >
> >
> > >
> > > So the bottom BDS would be unrefed before being unlocked.
>
> I don't see a problem with that, we can do the unlock before unref the node if
> we want.
My concern is that mirror.c does the unref and don't own the Blocker by itself.
The blocker is owned by the blockjob so it's difficult for mirror.c to do the unblock.
>
> Fam
next prev parent reply other threads:[~2014-06-23 5:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 20:01 [Qemu-devel] [PATCH] Recursive blocker Benoît Canet
2014-06-19 20:01 ` [Qemu-devel] [PATCH] block: Make op blocker recursive Benoît Canet
2014-06-19 20:13 ` Eric Blake
2014-06-19 20:20 ` Benoît Canet
2014-06-19 20:26 ` Eric Blake
2014-06-19 20:36 ` Benoît Canet
2014-06-20 5:01 ` Fam Zheng
2014-06-20 15:30 ` Eric Blake
2014-06-21 8:53 ` Fam Zheng
2014-06-21 10:45 ` Benoît Canet
2014-06-21 15:15 ` Fam Zheng
2014-06-21 15:39 ` Benoît Canet
2014-06-21 15:40 ` Benoît Canet
2014-06-23 4:32 ` Fam Zheng
2014-06-23 5:17 ` Benoît Canet [this message]
2014-06-23 7:07 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623051731.GA21371@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).