* [Qemu-devel] [PATCH] block/iscsi: fix init value for iTask->retries
@ 2014-06-18 16:40 Peter Lieven
2014-06-23 8:06 ` Stefan Hajnoczi
2014-06-23 8:13 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Peter Lieven @ 2014-06-18 16:40 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, pbonzini, Peter Lieven, stefanha
during rebasing the changed init value for the
retry counter was missed. This resulted in no retries
being performed at all.
Signed-off-by: Peter Lieven <pl@kamp.de>
---
block/iscsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 83c7992..327353c 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -216,7 +216,6 @@ static void iscsi_co_init_iscsitask(IscsiLun *iscsilun, struct IscsiTask *iTask)
{
*iTask = (struct IscsiTask) {
.co = qemu_coroutine_self(),
- .retries = ISCSI_CMD_RETRIES,
.iscsilun = iscsilun,
};
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] block/iscsi: fix init value for iTask->retries
2014-06-18 16:40 [Qemu-devel] [PATCH] block/iscsi: fix init value for iTask->retries Peter Lieven
@ 2014-06-23 8:06 ` Stefan Hajnoczi
2014-06-23 8:13 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2014-06-23 8:06 UTC (permalink / raw)
To: Peter Lieven; +Cc: kwolf, pbonzini, qemu-devel, stefanha
[-- Attachment #1: Type: text/plain, Size: 408 bytes --]
On Wed, Jun 18, 2014 at 06:40:11PM +0200, Peter Lieven wrote:
> during rebasing the changed init value for the
> retry counter was missed. This resulted in no retries
> being performed at all.
>
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> block/iscsi.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] block/iscsi: fix init value for iTask->retries
2014-06-18 16:40 [Qemu-devel] [PATCH] block/iscsi: fix init value for iTask->retries Peter Lieven
2014-06-23 8:06 ` Stefan Hajnoczi
@ 2014-06-23 8:13 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2014-06-23 8:13 UTC (permalink / raw)
To: Peter Lieven; +Cc: kwolf, pbonzini, qemu-devel, stefanha
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
On Wed, Jun 18, 2014 at 06:40:11PM +0200, Peter Lieven wrote:
> during rebasing the changed init value for the
> retry counter was missed. This resulted in no retries
> being performed at all.
>
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> block/iscsi.c | 1 -
> 1 file changed, 1 deletion(-)
Nevermind, Paolo already applied this via the SCSI tree.
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-23 8:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-18 16:40 [Qemu-devel] [PATCH] block/iscsi: fix init value for iTask->retries Peter Lieven
2014-06-23 8:06 ` Stefan Hajnoczi
2014-06-23 8:13 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).