From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WyzjO-0004X9-Nq for qemu-devel@nongnu.org; Mon, 23 Jun 2014 04:36:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WyzjF-0000av-Nu for qemu-devel@nongnu.org; Mon, 23 Jun 2014 04:36:02 -0400 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:44529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WyzjF-0000al-H6 for qemu-devel@nongnu.org; Mon, 23 Jun 2014 04:35:53 -0400 Received: by mail-wi0-f170.google.com with SMTP id cc10so3748371wib.5 for ; Mon, 23 Jun 2014 01:35:52 -0700 (PDT) Date: Mon, 23 Jun 2014 16:35:44 +0800 From: Stefan Hajnoczi Message-ID: <20140623083544.GA10862@stefanha-thinkpad.redhat.com> References: <1403043250-28472-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Content-Disposition: inline In-Reply-To: <1403043250-28472-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] block: Fix unset "filename" for certain drivers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 18, 2014 at 12:14:08AM +0200, Max Reitz wrote: > For some protocol block drivers, the "filename" attribute in their BDSs > is unset due to bdrv_file_open() removing it from the options QDict > before bdrv_open_common() is able to copy it into the BDS. Fix this by > not removing it until until bdrv_open_common() has indeed copied it. >=20 >=20 > Max Reitz (2): > block: Do not prematurely remove "filename" > iotests: Add test for set "filename" for NBD >=20 > block.c | 12 ++++++-- > tests/qemu-iotests/097 | 72 ++++++++++++++++++++++++++++++++++++++++= ++++++ > tests/qemu-iotests/097.out | 13 +++++++++ > tests/qemu-iotests/group | 1 + > 4 files changed, 95 insertions(+), 3 deletions(-) > create mode 100755 tests/qemu-iotests/097 > create mode 100644 tests/qemu-iotests/097.out Please check qemu-iotests 051. Dropping from block queue for now. 051 5s ... - output mismatch (see 051.out.bad) --- 051.out 2014-06-20 15:12:57.034266987 +0800 +++ 051.out.bad 2014-06-23 16:34:37.880591037 +0800 @@ -237,7 +237,8 @@ (qemu) quit =20 Testing: -drive file=3DTEST_DIR/t.qcow2,file.driver=3Dqcow2 -QEMU_PROG: -drive file=3DTEST_DIR/t.qcow2,file.driver=3Dqcow2: could not o= pen disk image TEST_DIR/t.qcow2: Block format 'qcow2' used by device '' doe= sn't support the option 'filename' +QEMU X.Y.Z monitor - type 'help' for more information +(qemu) quit --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTp+bgAAoJEJykq7OBq3PId1AH/1ZWwkbag9JlXvGaK+iOxob6 wwKhxCkn3Pq6CnTGl13WBILFLpuY4zm/FB2GnTLRCt/oz5UpxYwTWBVCu6SCwMo4 FTadND3x2IJbkO4Fw7+S39ORHa6ty9elf0Y1/xCim5kliHqYGiTcrwDS2GRNqazY 54wINESfzY/fXdB5ffn4Ni5ldzeojE30LOcq4X3EAhnMdKB++a3oX/NEH7ym0T4d LvfWNctEURlBBAbf1kUYVZv2Jdh30rFZN8ESpvEAFJYdiOjS3haW9Vo3ZhreoBGW y0Ted3OogBTPjAz/Wu4lYUYBO9Wk+mJSH9EJybAFCFExYFc6xaDqcSeCXElyqD4= =givF -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc--