qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Jia Liu <proljc@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] openrisc: fix comment
Date: Tue, 24 Jun 2014 08:06:05 +0200	[thread overview]
Message-ID: <20140624080605.628c7874@nial.usersys.redhat.com> (raw)
In-Reply-To: <1403585199-25321-1-git-send-email-mst@redhat.com>

On Tue, 24 Jun 2014 07:46:43 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> Fix English in comment:
> 
> s/the each/each/
> 
> s/  \*\// \*\//
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  target-openrisc/translate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target-openrisc/translate.c b/target-openrisc/translate.c
> index b728718..55ff935 100644
> --- a/target-openrisc/translate.c
> +++ b/target-openrisc/translate.c
> @@ -531,14 +531,14 @@ static void dec_calc(DisasContext *dc, uint32_t insn)
>                  TCGv_i64 high = tcg_temp_new_i64();
>                  TCGv_i32 sr_ove = tcg_temp_local_new_i32();
>                  int lab = gen_new_label();
> -                /* Calculate the each result.  */
> +                /* Calculate each result. */
>                  tcg_gen_extu_i32_i64(tra, cpu_R[ra]);
>                  tcg_gen_extu_i32_i64(trb, cpu_R[rb]);
>                  tcg_gen_mul_i64(result, tra, trb);
>                  tcg_temp_free_i64(tra);
>                  tcg_temp_free_i64(trb);
>                  tcg_gen_shri_i64(high, result, TARGET_LONG_BITS);
> -                /* Overflow or not.  */
> +                /* Overflow or not. */
>                  tcg_gen_brcondi_i64(TCG_COND_EQ, high, 0x00000000, lab);
>                  tcg_gen_ori_tl(cpu_sr, cpu_sr, (SR_OV | SR_CY));
>                  tcg_gen_andi_tl(sr_ove, cpu_sr, SR_OVE);

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

      reply	other threads:[~2014-06-24  6:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24  4:46 [Qemu-devel] [PATCH] openrisc: fix comment Michael S. Tsirkin
2014-06-24  6:06 ` Igor Mammedov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140624080605.628c7874@nial.usersys.redhat.com \
    --to=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=proljc@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).