* [Qemu-devel] [PATCH] openrisc: fix comment
@ 2014-06-24 4:46 Michael S. Tsirkin
2014-06-24 6:06 ` Igor Mammedov
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2014-06-24 4:46 UTC (permalink / raw)
To: qemu-devel; +Cc: Jia Liu
Fix English in comment:
s/the each/each/
s/ \*\// \*\//
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
target-openrisc/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-openrisc/translate.c b/target-openrisc/translate.c
index b728718..55ff935 100644
--- a/target-openrisc/translate.c
+++ b/target-openrisc/translate.c
@@ -531,14 +531,14 @@ static void dec_calc(DisasContext *dc, uint32_t insn)
TCGv_i64 high = tcg_temp_new_i64();
TCGv_i32 sr_ove = tcg_temp_local_new_i32();
int lab = gen_new_label();
- /* Calculate the each result. */
+ /* Calculate each result. */
tcg_gen_extu_i32_i64(tra, cpu_R[ra]);
tcg_gen_extu_i32_i64(trb, cpu_R[rb]);
tcg_gen_mul_i64(result, tra, trb);
tcg_temp_free_i64(tra);
tcg_temp_free_i64(trb);
tcg_gen_shri_i64(high, result, TARGET_LONG_BITS);
- /* Overflow or not. */
+ /* Overflow or not. */
tcg_gen_brcondi_i64(TCG_COND_EQ, high, 0x00000000, lab);
tcg_gen_ori_tl(cpu_sr, cpu_sr, (SR_OV | SR_CY));
tcg_gen_andi_tl(sr_ove, cpu_sr, SR_OVE);
--
MST
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] openrisc: fix comment
2014-06-24 4:46 [Qemu-devel] [PATCH] openrisc: fix comment Michael S. Tsirkin
@ 2014-06-24 6:06 ` Igor Mammedov
0 siblings, 0 replies; 2+ messages in thread
From: Igor Mammedov @ 2014-06-24 6:06 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel, Jia Liu
On Tue, 24 Jun 2014 07:46:43 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> Fix English in comment:
>
> s/the each/each/
>
> s/ \*\// \*\//
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> target-openrisc/translate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-openrisc/translate.c b/target-openrisc/translate.c
> index b728718..55ff935 100644
> --- a/target-openrisc/translate.c
> +++ b/target-openrisc/translate.c
> @@ -531,14 +531,14 @@ static void dec_calc(DisasContext *dc, uint32_t insn)
> TCGv_i64 high = tcg_temp_new_i64();
> TCGv_i32 sr_ove = tcg_temp_local_new_i32();
> int lab = gen_new_label();
> - /* Calculate the each result. */
> + /* Calculate each result. */
> tcg_gen_extu_i32_i64(tra, cpu_R[ra]);
> tcg_gen_extu_i32_i64(trb, cpu_R[rb]);
> tcg_gen_mul_i64(result, tra, trb);
> tcg_temp_free_i64(tra);
> tcg_temp_free_i64(trb);
> tcg_gen_shri_i64(high, result, TARGET_LONG_BITS);
> - /* Overflow or not. */
> + /* Overflow or not. */
> tcg_gen_brcondi_i64(TCG_COND_EQ, high, 0x00000000, lab);
> tcg_gen_ori_tl(cpu_sr, cpu_sr, (SR_OV | SR_CY));
> tcg_gen_andi_tl(sr_ove, cpu_sr, SR_OVE);
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-24 6:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-24 4:46 [Qemu-devel] [PATCH] openrisc: fix comment Michael S. Tsirkin
2014-06-24 6:06 ` Igor Mammedov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).