From: Riku Voipio <riku.voipio@iki.fi>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Riku Voipio <riku.voipio@linaro.org>,
schwab@suse.de, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
proljc@gmail.com
Subject: Re: [Qemu-devel] AArch64 linux-user: SA_ONSTACK usage in get_sigframe
Date: Tue, 24 Jun 2014 15:15:29 +0300 [thread overview]
Message-ID: <20140624121529.GA21242@afflict.kos.to> (raw)
In-Reply-To: <CABoDooPey1kXt=KOBEnSS8Es6Zar2X_iMzVCA9nPYBdE+8gm-g@mail.gmail.com>
On Mon, Jun 23, 2014 at 06:15:03PM +0200, Laurent Desnogues wrote:
> Hello,
>
> in linux-user/signal.c the code for AArch64 get_sigframe reads like this:
>
> if ((ka->sa_flags & SA_ONSTACK) && !sas_ss_flags(sp)) {
>
> Shouldn't that be TARGET_SA_ONSTACK?
> The same question applies to Microblaze and OpenRISC.
Correct. Most people wont just notice since SA_ONSTACK appears to be
0x08000000 for everything but alpha and parisc where it is 1.
Riku
prev parent reply other threads:[~2014-06-24 12:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 16:15 [Qemu-devel] AArch64 linux-user: SA_ONSTACK usage in get_sigframe Laurent Desnogues
2014-06-24 12:15 ` Riku Voipio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140624121529.GA21242@afflict.kos.to \
--to=riku.voipio@iki.fi \
--cc=edgar.iglesias@gmail.com \
--cc=laurent.desnogues@gmail.com \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@linaro.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).