* [Qemu-devel] AArch64 linux-user: SA_ONSTACK usage in get_sigframe
@ 2014-06-23 16:15 Laurent Desnogues
2014-06-24 12:15 ` Riku Voipio
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Desnogues @ 2014-06-23 16:15 UTC (permalink / raw)
To: qemu-devel@nongnu.org, Riku Voipio; +Cc: Edgar E. Iglesias, proljc, schwab
Hello,
in linux-user/signal.c the code for AArch64 get_sigframe reads like this:
if ((ka->sa_flags & SA_ONSTACK) && !sas_ss_flags(sp)) {
Shouldn't that be TARGET_SA_ONSTACK?
The same question applies to Microblaze and OpenRISC.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] AArch64 linux-user: SA_ONSTACK usage in get_sigframe
2014-06-23 16:15 [Qemu-devel] AArch64 linux-user: SA_ONSTACK usage in get_sigframe Laurent Desnogues
@ 2014-06-24 12:15 ` Riku Voipio
0 siblings, 0 replies; 2+ messages in thread
From: Riku Voipio @ 2014-06-24 12:15 UTC (permalink / raw)
To: Laurent Desnogues
Cc: Edgar E. Iglesias, Riku Voipio, schwab, qemu-devel@nongnu.org,
proljc
On Mon, Jun 23, 2014 at 06:15:03PM +0200, Laurent Desnogues wrote:
> Hello,
>
> in linux-user/signal.c the code for AArch64 get_sigframe reads like this:
>
> if ((ka->sa_flags & SA_ONSTACK) && !sas_ss_flags(sp)) {
>
> Shouldn't that be TARGET_SA_ONSTACK?
> The same question applies to Microblaze and OpenRISC.
Correct. Most people wont just notice since SA_ONSTACK appears to be
0x08000000 for everything but alpha and parisc where it is 1.
Riku
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-24 12:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-23 16:15 [Qemu-devel] AArch64 linux-user: SA_ONSTACK usage in get_sigframe Laurent Desnogues
2014-06-24 12:15 ` Riku Voipio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).