qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kurz <gkurz@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Juan Quintela" <quintela@redhat.com>,
	"Rusty Russell" <rusty@rustcorp.com.au>,
	"Alexander Graf" <agraf@suse.de>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	aneesh.kumar@linux.vnet.ibm.com,
	"Anthony Liguori" <aliguori@amazon.com>,
	"Amit Shah" <amit.shah@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH v9 11/22] cpu: introduce CPUClass::virtio_is_big_endian()
Date: Tue, 24 Jun 2014 19:33:21 +0200	[thread overview]
Message-ID: <20140624172636.17522.32936.stgit@bahia.local> (raw)
In-Reply-To: <20140624151955.17522.62537.stgit@bahia.local>

If we want to support targets that can change endianness (modern PPC and
ARM for the moment), we need to add a per-CPU class method to be called
from the virtio code. The virtio_ prefix in the name is a hint for people
to avoid misusage (aka. anywhere but from the virtio code).

The default behaviour is to return the compile-time default target
endianness.

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
---
 Changes since v8:
 - removed the globally visible cpu_virtio_is_big_endian() helper (code is
   now called directly from virtio, see next patch)

 include/qom/cpu.h |    1 +
 qom/cpu.c         |    6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index 4b352a2..1aafbf5 100644
--- a/include/qom/cpu.h
+++ b/include/qom/cpu.h
@@ -116,6 +116,7 @@ typedef struct CPUClass {
     CPUUnassignedAccess do_unassigned_access;
     void (*do_unaligned_access)(CPUState *cpu, vaddr addr,
                                 int is_write, int is_user, uintptr_t retaddr);
+    bool (*virtio_is_big_endian)(CPUState *cpu);
     int (*memory_rw_debug)(CPUState *cpu, vaddr addr,
                            uint8_t *buf, int len, bool is_write);
     void (*dump_state)(CPUState *cpu, FILE *f, fprintf_function cpu_fprintf,
diff --git a/qom/cpu.c b/qom/cpu.c
index fada2d4..b32dd0a 100644
--- a/qom/cpu.c
+++ b/qom/cpu.c
@@ -196,6 +196,11 @@ static int cpu_common_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg)
     return 0;
 }
 
+bool target_words_bigendian(void);
+static bool cpu_common_virtio_is_big_endian(CPUState *cpu)
+{
+    return target_words_bigendian();
+}
 
 void cpu_dump_state(CPUState *cpu, FILE *f, fprintf_function cpu_fprintf,
                     int flags)
@@ -334,6 +339,7 @@ static void cpu_class_init(ObjectClass *klass, void *data)
     k->write_elf64_note = cpu_common_write_elf64_note;
     k->gdb_read_register = cpu_common_gdb_read_register;
     k->gdb_write_register = cpu_common_gdb_write_register;
+    k->virtio_is_big_endian = cpu_common_virtio_is_big_endian;
     dc->realize = cpu_common_realizefn;
     /*
      * Reason: CPUs still need special care by board code: wiring up

  parent reply	other threads:[~2014-06-24 17:33 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 17:06 [Qemu-devel] [PATCH v9 00/22] legacy virtio support for cross-endian targets Greg Kurz
2014-06-24 17:11 ` [Qemu-devel] [PATCH v9 01/22] virtio-net: byteswap virtio-net header Greg Kurz
2014-06-24 17:13 ` [Qemu-devel] [PATCH v9 02/22] virtio-serial: don't migrate the config space Greg Kurz
2014-06-26  9:57   ` Amit Shah
2014-06-24 17:15 ` [Qemu-devel] [PATCH v9 03/22] virtio: introduce device specific migration calls Greg Kurz
2014-06-24 17:19 ` [Qemu-devel] [PATCH v9 04/22] virtio-net: implement per-device " Greg Kurz
2014-06-24 17:19 ` [Qemu-devel] [PATCH v9 05/22] virtio-blk: " Greg Kurz
2014-06-24 17:19 ` [Qemu-devel] [PATCH v9 06/22] virtio-serial: " Greg Kurz
2014-06-24 17:20 ` [Qemu-devel] [PATCH v9 07/22] virtio-balloon: " Greg Kurz
2014-06-24 17:20 ` [Qemu-devel] [PATCH v9 08/22] virtio-rng: " Greg Kurz
2014-06-24 17:22 ` [Qemu-devel] [PATCH v9 09/22] virtio: add subsections to the migration stream Greg Kurz
2014-06-24 17:25 ` [Qemu-devel] [PATCH v9 00/22] legacy virtio support for cross-endian targets Michael S. Tsirkin
2014-06-24 18:16   ` Greg Kurz
2014-06-24 17:26 ` [Qemu-devel] [PATCH v9 10/22] exec: introduce target_words_bigendian() helper Greg Kurz
2014-06-24 17:33 ` Greg Kurz [this message]
2014-06-24 17:38 ` [Qemu-devel] [PATCH v9 12/22] virtio: add endian-ambivalent support to VirtIODevice Greg Kurz
2014-06-24 17:39 ` [Qemu-devel] [PATCH v9 13/22] virtio: memory accessors for endian-ambivalent targets Greg Kurz
2014-06-24 17:40 ` [Qemu-devel] [PATCH v9 14/22] virtio: allow byte swapping for vring Greg Kurz
2014-06-24 17:42 ` [Qemu-devel] [PATCH v9 15/22] virtio-net: use virtio wrappers to access headers Greg Kurz
2014-06-24 17:43 ` [Qemu-devel] [PATCH v9 16/22] virtio-balloon: use virtio wrappers to access page frame numbers Greg Kurz
2014-06-24 17:43 ` [Qemu-devel] [PATCH v9 17/22] virtio-blk: use virtio wrappers to access headers Greg Kurz
2014-06-24 17:48 ` [Qemu-devel] [PATCH v9 18/22] virtio-scsi: " Greg Kurz
2014-06-24 17:49 ` [Qemu-devel] [PATCH v9 19/22] virtio-serial-bus: " Greg Kurz
2014-06-24 17:49 ` [Qemu-devel] [PATCH v9 20/22] virtio-9p: " Greg Kurz
2014-06-24 17:51 ` [Qemu-devel] [PATCH v9 21/22] target-ppc: enable virtio endian ambivalent support Greg Kurz
2014-06-24 17:55 ` [Qemu-devel] [PATCH v9 22/22] vhost-net: disable when cross-endian Greg Kurz
2014-06-29 15:07   ` Michael S. Tsirkin
2014-06-29 15:13 ` [Qemu-devel] [PATCH v9 00/22] legacy virtio support for cross-endian targets Michael S. Tsirkin
2014-06-29 16:02   ` Alexander Graf
2014-06-30  6:48   ` Greg Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140624172636.17522.32936.stgit@bahia.local \
    --to=gkurz@linux.vnet.ibm.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=aliguori@amazon.com \
    --cc=amit.shah@redhat.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).