From: Greg Kurz <gkurz@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Rusty Russell" <rusty@rustcorp.com.au>,
"Alexander Graf" <agraf@suse.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
aneesh.kumar@linux.vnet.ibm.com,
"Anthony Liguori" <aliguori@amazon.com>,
"Amit Shah" <amit.shah@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH v9 16/22] virtio-balloon: use virtio wrappers to access page frame numbers
Date: Tue, 24 Jun 2014 19:43:22 +0200 [thread overview]
Message-ID: <20140624174302.17522.19977.stgit@bahia.local> (raw)
In-Reply-To: <20140624151955.17522.62537.stgit@bahia.local>
From: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
[ pass VirtIODevice * to memory accessors,
Greg Kurz <gkurz@linux.vnet.ibm.com> ]
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: Alexander Graf <agraf@suse.de>
---
hw/virtio/virtio-balloon.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index e0ed5ee..2c30b3d 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -31,6 +31,7 @@
#endif
#include "hw/virtio/virtio-bus.h"
+#include "hw/virtio/virtio-access.h"
static void balloon_page(void *addr, int deflate)
{
@@ -206,8 +207,9 @@ static void virtio_balloon_handle_output(VirtIODevice *vdev, VirtQueue *vq)
while (iov_to_buf(elem.out_sg, elem.out_num, offset, &pfn, 4) == 4) {
ram_addr_t pa;
ram_addr_t addr;
+ int p = virtio_ldl_p(vdev, &pfn);
- pa = (ram_addr_t)ldl_p(&pfn) << VIRTIO_BALLOON_PFN_SHIFT;
+ pa = (ram_addr_t) p << VIRTIO_BALLOON_PFN_SHIFT;
offset += 4;
/* FIXME: remove get_system_memory(), but how? */
@@ -248,8 +250,8 @@ static void virtio_balloon_receive_stats(VirtIODevice *vdev, VirtQueue *vq)
while (iov_to_buf(elem->out_sg, elem->out_num, offset, &stat, sizeof(stat))
== sizeof(stat)) {
- uint16_t tag = tswap16(stat.tag);
- uint64_t val = tswap64(stat.val);
+ uint16_t tag = virtio_tswap16(vdev, stat.tag);
+ uint64_t val = virtio_tswap64(vdev, stat.val);
offset += sizeof(stat);
if (tag < VIRTIO_BALLOON_S_NR)
next prev parent reply other threads:[~2014-06-24 17:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 17:06 [Qemu-devel] [PATCH v9 00/22] legacy virtio support for cross-endian targets Greg Kurz
2014-06-24 17:11 ` [Qemu-devel] [PATCH v9 01/22] virtio-net: byteswap virtio-net header Greg Kurz
2014-06-24 17:13 ` [Qemu-devel] [PATCH v9 02/22] virtio-serial: don't migrate the config space Greg Kurz
2014-06-26 9:57 ` Amit Shah
2014-06-24 17:15 ` [Qemu-devel] [PATCH v9 03/22] virtio: introduce device specific migration calls Greg Kurz
2014-06-24 17:19 ` [Qemu-devel] [PATCH v9 04/22] virtio-net: implement per-device " Greg Kurz
2014-06-24 17:19 ` [Qemu-devel] [PATCH v9 05/22] virtio-blk: " Greg Kurz
2014-06-24 17:19 ` [Qemu-devel] [PATCH v9 06/22] virtio-serial: " Greg Kurz
2014-06-24 17:20 ` [Qemu-devel] [PATCH v9 07/22] virtio-balloon: " Greg Kurz
2014-06-24 17:20 ` [Qemu-devel] [PATCH v9 08/22] virtio-rng: " Greg Kurz
2014-06-24 17:22 ` [Qemu-devel] [PATCH v9 09/22] virtio: add subsections to the migration stream Greg Kurz
2014-06-24 17:25 ` [Qemu-devel] [PATCH v9 00/22] legacy virtio support for cross-endian targets Michael S. Tsirkin
2014-06-24 18:16 ` Greg Kurz
2014-06-24 17:26 ` [Qemu-devel] [PATCH v9 10/22] exec: introduce target_words_bigendian() helper Greg Kurz
2014-06-24 17:33 ` [Qemu-devel] [PATCH v9 11/22] cpu: introduce CPUClass::virtio_is_big_endian() Greg Kurz
2014-06-24 17:38 ` [Qemu-devel] [PATCH v9 12/22] virtio: add endian-ambivalent support to VirtIODevice Greg Kurz
2014-06-24 17:39 ` [Qemu-devel] [PATCH v9 13/22] virtio: memory accessors for endian-ambivalent targets Greg Kurz
2014-06-24 17:40 ` [Qemu-devel] [PATCH v9 14/22] virtio: allow byte swapping for vring Greg Kurz
2014-06-24 17:42 ` [Qemu-devel] [PATCH v9 15/22] virtio-net: use virtio wrappers to access headers Greg Kurz
2014-06-24 17:43 ` Greg Kurz [this message]
2014-06-24 17:43 ` [Qemu-devel] [PATCH v9 17/22] virtio-blk: " Greg Kurz
2014-06-24 17:48 ` [Qemu-devel] [PATCH v9 18/22] virtio-scsi: " Greg Kurz
2014-06-24 17:49 ` [Qemu-devel] [PATCH v9 19/22] virtio-serial-bus: " Greg Kurz
2014-06-24 17:49 ` [Qemu-devel] [PATCH v9 20/22] virtio-9p: " Greg Kurz
2014-06-24 17:51 ` [Qemu-devel] [PATCH v9 21/22] target-ppc: enable virtio endian ambivalent support Greg Kurz
2014-06-24 17:55 ` [Qemu-devel] [PATCH v9 22/22] vhost-net: disable when cross-endian Greg Kurz
2014-06-29 15:07 ` Michael S. Tsirkin
2014-06-29 15:13 ` [Qemu-devel] [PATCH v9 00/22] legacy virtio support for cross-endian targets Michael S. Tsirkin
2014-06-29 16:02 ` Alexander Graf
2014-06-30 6:48 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140624174302.17522.19977.stgit@bahia.local \
--to=gkurz@linux.vnet.ibm.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aliguori@amazon.com \
--cc=amit.shah@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).