From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42565)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <viro@ftp.linux.org.uk>) id 1WzXcY-0003q2-80
	for qemu-devel@nongnu.org; Tue, 24 Jun 2014 16:47:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <viro@ftp.linux.org.uk>) id 1WzXcU-00015F-TU
	for qemu-devel@nongnu.org; Tue, 24 Jun 2014 16:47:14 -0400
Received: from zeniv.linux.org.uk ([2002:c35c:fd02::1]:38997)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <viro@ftp.linux.org.uk>) id 1WzXcU-000155-Ls
	for qemu-devel@nongnu.org; Tue, 24 Jun 2014 16:47:10 -0400
Date: Tue, 24 Jun 2014 21:47:09 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
Message-ID: <20140624204709.GA18016@ZenIV.linux.org.uk>
References: <20140624043423.GX18016@ZenIV.linux.org.uk>
	<53A9C205.6070806@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53A9C205.6070806@twiddle.net>
Sender: Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Tue, Jun 24, 2014 at 11:23:01AM -0700, Richard Henderson wrote:
> >      env->error_code = error;
> >      if (retaddr) {
> >          cpu_restore_state(cs, retaddr);
> > +	env->pc += 4;
> 
> This one needs a different fix, since dynamic_excp is also used from
> alpha_cpu_unassigned_access, and I'm pretty sure the mchk should have the
> address of the memory insn.  But that should be easy to fix up.

That's not a problem, actually - there we have
    dynamic_excp(env, 0, EXCP_MCHK, 0);
so retaddr is going to be 0 and that env->pc += 4 won't be reached at all...