From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39361)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WzffP-000199-Ie
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 01:22:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WzffJ-0001FC-E6
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 01:22:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53117)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WzffJ-0001F6-4S
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 01:22:37 -0400
Date: Wed, 25 Jun 2014 08:22:57 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140625052257.GE21297@redhat.com>
References: <1403632924-16603-1-git-send-email-ehabkost@redhat.com>
	<53AA366B.1030806@ozlabs.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53AA366B.1030806@ozlabs.ru>
Subject: Re: [Qemu-devel] [PATCH 0/4] Introduce common QEMU_COMPAT_* macros
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Peter Maydell <peter.maydell@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, Marcel Apfelbaum <marcel.a@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Paul Mackerras <paulus@samba.org>, Anthony Liguori <aliguori@amazon.com>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, Alexander Graf <agraf@suse.com>

On Wed, Jun 25, 2014 at 12:39:39PM +1000, Alexey Kardashevskiy wrote:
> On 06/25/2014 04:02 AM, Eduardo Habkost wrote:
> > This series is an attempt to make the compat_props lists from the PC code
> > reusable by other machine-types. All the compat bits that are on those lists are
> > not tied to a specific machine-type, but instead to the device code that was
> > present on a given QEMU version.
> > 
> > The last patch is a proposal to simply eliminate the PC-specific compat props
> > macros, because we don't really need them today. All compat properties we have
> > can be on global QEMU-version-specific lists, because PC-specific properties are
> > not going to affect other machine-types anyway.
> 
> The idea is cool, the separation of which properties go to boards.h and
> which stay in hw/i386/pc_piix.c is not clear though (PIIX is unlikely to be
> wanted somewhere else but virtio is).

virtio compat < 2.0 is not useful to non x86 either.


> 
> > 
> > Eduardo Habkost (4):
> >   q35: Move q35-specific compat macros to pc_q35.c
> >   pc: Eliminate nesting of common PC_COMPAT_* macros
> >   machine: Introduce QEMU_COMPAT_* macros
> >   [RFC] Eliminate PC-specific compat_props
> > 
> >  hw/i386/pc_piix.c    |  31 +++++--
> >  hw/i386/pc_q35.c     |  19 +++++
> >  include/hw/boards.h  | 207 +++++++++++++++++++++++++++++++++++++++++++++++
> >  include/hw/i386/pc.h | 224 ---------------------------------------------------
> >  4 files changed, 251 insertions(+), 230 deletions(-)
> 
> 
> 
> 
> 
> -- 
> Alexey