From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45230)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WzgGs-0003Fv-R6
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 02:01:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WzgGn-00054x-2n
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 02:01:26 -0400
Date: Wed, 25 Jun 2014 09:01:40 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140625060140.GA21752@redhat.com>
References: <1403650675-3368-1-git-send-email-ehabkost@redhat.com>
	<20140625060059.GC21553@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140625060059.GC21553@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] pc: Fix "prog_if" typo on PC_COMPAT_2_0
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

On Wed, Jun 25, 2014 at 09:00:59AM +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 24, 2014 at 07:57:55PM -0300, Eduardo Habkost wrote:
> > The property name is "prog_if", not "prof_if".
> > 
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > Cc: BALATON Zoltan <balaton@eik.bme.hu>
> 
> Should be reported-by, by the way.
> Cc: means "I have notified this person just in case".

Fixed up on my branch no need to repost.

> > ---
> >  include/hw/i386/pc.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> > index 486e98f..1331d5a 100644
> > --- a/include/hw/i386/pc.h
> > +++ b/include/hw/i386/pc.h
> > @@ -358,7 +358,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
> >          },\
> >          {\
> >              .driver   = "pci-serial-2x",\
> > -            .property = "prof_if",\
> > +            .property = "prog_if",\
> >              .value    = stringify(0),\
> >          },\
> >          {\
> > -- 
> > 1.9.3