Re: [Qemu-devel] [PATCH 2/2] char: report frontend open/closed state in 'query-chardev'

[Luiz Capitulino <lcapitulino@redhat.com>]

On Wed, 25 Jun 2014 15:25:28 +0200
Laszlo Ersek <lersek@redhat.com> wrote:

> On 06/25/14 15:16, Luiz Capitulino wrote:
> > On Wed, 25 Jun 2014 07:14:08 -0600
> > Eric Blake <eblake@redhat.com> wrote:
> > 
> >> On 06/25/2014 07:02 AM, Luiz Capitulino wrote:
> >>> On Tue, 24 Jun 2014 08:36:36 -0600
> >>> Eric Blake <eblake@redhat.com> wrote:
> >>>
> >>>> [cc'ing Luiz]
> >>>>
> >>>> On 06/24/2014 08:21 AM, Laszlo Ersek wrote:
> >>>>> On 05/29/14 23:05, Eric Blake wrote:
> >>>>>> On 05/29/2014 02:43 PM, Laszlo Ersek wrote:
> >>>>
> >>>>>>> In this series I try to implement the ideas that (I believe) were
> >>>>>>> suggested by Gerd and Amit in
> >>>>>>> <https://bugzilla.redhat.com/show_bug.cgi?id=1080376>.
> >>>>>>>
> >>
> >>>>>
> >>>>> I'm thinking about resuming work on this. Wenchao's series has been
> >>>>> applied (ends at commit 75175173). We're between soft and hard freeze
> >>>>> now. Should I aim at 2.1 or 2.2?
> >>>>
> >>>> This series was posted before soft freeze, but adds a new feature.  If
> >>>> we're going to get it in the 2.1 release, it must be before hard freeze.
> >>>>  I'll leave it up to Luiz whether a QMP addition this late in the game
> >>>> is safe to take, although my personal opinion is that since it was
> >>>> proposed before soft freeze, and DOES make life easier for libvirt, it
> >>>> is worth a strong consideration.
> >>>
> >>> Has this series being reviewed?
> >>
> >> v1 was reviewed pre-freeze; Laszlo has not yet posted v2 (in part
> >> because it was waiting on the qapi-as-event series which is now finally
> >> upstream).
> > 
> > I'm fine with having it for 2.1. It would be great if v2 is posted today or
> > tomorrow.
> 
> It would be great indeed, but today is quite impossible for me. Tomorrow
> might work, however I usually mess up when I rush things. Until end of
> the week (Sunday) is more realistic for me, but it's probably not
> convenient for you. I'm OK if we push this to 2.2.

I'm planning to send a pull request on Friday. We're going to have an extended
holiday where I live until Tuesday (inclusive). I'll probably work on Monday,
but it'd be better to be done with non-crucial stuff before that.