Re: [Qemu-devel] [PATCH] numa: check for busy memory backend

[Igor Mammedov <imammedo@redhat.com>]

On Wed, 25 Jun 2014 17:04:14 +0800
Hu Tao <hutao@cn.fujitsu.com> wrote:

> ..to prevent one memory backend from being used by more than one numa
> node.
> 
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>  numa.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/numa.c b/numa.c
> index e471afe..6c1c554 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -279,6 +279,13 @@ void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner,
>              exit(1);
>          }
>  
> +        if (memory_region_is_mapped(seg)) {
> +            char *path = object_get_canonical_path_component(OBJECT(backend));
> +            error_report("memory backend %s is busy", path);
> +            g_free(path);
> +            exit(1);
s/1/EXIT_FAILURE/ please

> +        }
> +
>          memory_region_add_subregion(mr, addr, seg);
>          vmstate_register_ram_global(seg);
>          addr += size;