From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48705)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WznvS-0008VM-6c
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 10:11:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WznvM-0000nc-1i
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 10:11:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39916)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WznvL-0000nN-OK
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 10:11:43 -0400
Date: Wed, 25 Jun 2014 17:12:03 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140625141203.GF14578@redhat.com>
References: <1403632924-16603-1-git-send-email-ehabkost@redhat.com>
	<1403632924-16603-5-git-send-email-ehabkost@redhat.com>
	<20140625045553.GA21297@redhat.com>
	<20140625132512.GZ3222@otherpad.lan.raisama.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140625132512.GZ3222@otherpad.lan.raisama.net>
Subject: Re: [Qemu-devel] [PATCH 4/4] [RFC] Eliminate PC-specific
	compat_props
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Marcel Apfelbaum <marcel.a@redhat.com>, Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Paul Mackerras <paulus@samba.org>, Anthony Liguori <aliguori@amazon.com>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, Alexander Graf <agraf@suse.com>

On Wed, Jun 25, 2014 at 10:25:12AM -0300, Eduardo Habkost wrote:
> On Wed, Jun 25, 2014 at 07:55:53AM +0300, Michael S. Tsirkin wrote:
> [...]
> > 
> > As far as I can tell this will break hpet,
> > because you set it incorrectly for PIIX
> > 
> >   #define QEMU_COMPAT_1_7 \
> >  @@ -179,6 +197,16 @@ struct MachineState {
> >           .driver   = TYPE_USB_DEVICE,\
> >           .property = "msos-desc",\
> >           .value    = "no",\
> >  +    },\
> >  +    {\
> >  +        .driver   = "PIIX4_PM",\
> >  +        .property = "acpi-pci-hotplug-with-bridge-support",\
> >  +        .value    = "off",\
> >  +    }, \
> >  +    {\
> >  +        .driver   = "hpet",\
> >  +        .property = HPET_INTCAP,\
> >  +        .value    = stringify(4),\
> >       }
> >   
> > 
> > AFAIK above is appropriate for Q35 but not PIIX.
> > 
> > See commit log for
> > commit 7a10ef51c2397ac4323bc786af02c58b413b5cd2
> >     hpet: enable to entitle more irq pins for hpet
> 
> I assume this was explained in the v2 commit message, and there was no
> bug here, right?
> 
> -- 
> Eduardo



yes.