qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Markus Armbruster" <armbru@redhat.com>,
	qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
	"Luiz Capitulino" <lcapitulino@redhat.com>,
	=?UTF-8?q?Andreas=20F=C3=A4rber?= <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v4] mc146818rtc: add rtc-reset-reinjection QMP command
Date: Wed, 25 Jun 2014 12:18:39 -0300	[thread overview]
Message-ID: <20140625151839.GA22830@amt.cnet> (raw)
In-Reply-To: <1403696346-9255-1-git-send-email-mst@redhat.com>

On Wed, Jun 25, 2014 at 02:40:12PM +0300, Michael S. Tsirkin wrote:
> It is necessary to reset RTC interrupt reinjection backlog if
> guest time is synchronized via a different mechanism, such as
> QGA's guest-set-time command.
> 
> Failing to do so causes both corrections to be applied (summed),
> resulting in an incorrect guest time.
> 
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> 
> Marcelo, is this right?
> 
> Changes from v3:
>     rebase on top of master
>     fixes error code
>     drop dead code

Yes, sorry about the trouble.

Thanks a lot Michael.

  parent reply	other threads:[~2014-06-25 15:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25 11:40 [Qemu-devel] [PATCH v4] mc146818rtc: add rtc-reset-reinjection QMP command Michael S. Tsirkin
2014-06-25 13:58 ` Eric Blake
2014-06-25 15:18 ` Marcelo Tosatti [this message]
2014-06-25 19:51 ` Luiz Capitulino
2014-06-26  5:59   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140625151839.GA22830@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).