From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48659)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1WzpNY-0002qv-VC
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:45:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1WzpNR-0004it-95
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:44:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5043)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1WzpNR-0004ip-1b
	for qemu-devel@nongnu.org; Wed, 25 Jun 2014 11:44:49 -0400
Date: Wed, 25 Jun 2014 12:18:39 -0300
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20140625151839.GA22830@amt.cnet>
References: <1403696346-9255-1-git-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1403696346-9255-1-git-send-email-mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4] mc146818rtc: add rtc-reset-reinjection
	QMP command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, =?us-ascii?B?PT9VVEYtOD9xP0FuZHJlYXM9MjBGPUMzPUE0cmJlcj89?= <afaerber@suse.de>

On Wed, Jun 25, 2014 at 02:40:12PM +0300, Michael S. Tsirkin wrote:
> It is necessary to reset RTC interrupt reinjection backlog if
> guest time is synchronized via a different mechanism, such as
> QGA's guest-set-time command.
> 
> Failing to do so causes both corrections to be applied (summed),
> resulting in an incorrect guest time.
> 
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> 
> Marcelo, is this right?
> 
> Changes from v3:
>     rebase on top of master
>     fixes error code
>     drop dead code

Yes, sorry about the trouble.

Thanks a lot Michael.