Re: [Qemu-devel] [PATCH v4 0/4] tests: add usb host adapter qtest cases

[Amos Kong <akong@redhat.com>]

On Mon, Jun 23, 2014 at 07:53:50PM +0800, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> This patch series base on my request usb host adapter hotplug/unplug
> series:
> 
> [PATCH v3 00/10] usb: usb host adapter hotplug
> http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00746.html

Looks good to me.

Reviewed-by: Amos Kong <akong@redhat.com>
 
> Changes since v3:
>  - rebase on latest qemu master
> 
> Changes since v2:
>   - add 'const' qualifier argument in usb_hcd_hotplug
>     function for building errors reported by Gerd
> 
> Changes since v1:
>  * By Andreas suggestion:
>   - rework hci-{ohci,uhci,xhci} files for functional tests
>   - add "cold-plug" test, "-device" in init funciton
>   - use QMP for device_add/del because of parsing security
>   - some other fixs
> 
>  * By Gerd suggestion:
>   - add an usb-hcd-hotplug-test.c file and collect hotplug
>     testing for all usb hcds
> 
> Thanks for your suggestion, please review again.
> 
> My "make check V=1" results:
> 
>  [...]
> TEST: tests/usb-hcd-ohci-test... (pid=20031)
>   /x86_64/ohci/pci/init:                                               OK
> PASS: tests/usb-hcd-ohci-test
> TEST: tests/usb-hcd-uhci-test... (pid=20034)
>   /x86_64/uhci/pci/init:                                               OK
> PASS: tests/usb-hcd-uhci-test
> TEST: tests/usb-hcd-ehci-test... (pid=20037)
>   /x86_64/ehci/pci/init:                                               OK
>   /x86_64/ehci/pci/uhci-port-1:                                        OK
>   /x86_64/ehci/pci/ehci-port-1:                                        OK
>   /x86_64/ehci/pci/ehci-config:                                        OK
>   /x86_64/ehci/pci/uhci-port-2:                                        OK
>   /x86_64/ehci/pci/ehci-port-2:                                        OK
> PASS: tests/usb-hcd-ehci-test
> TEST: tests/usb-hcd-xhci-test... (pid=20040)
>   /x86_64/xhci/pci/init:                                               OK
> PASS: tests/usb-hcd-xhci-test
> TEST: tests/usb-hcd-hotplug-test... (pid=20043)
>   /x86_64/usb/hcd/pci/ohci-hotplug:                                    OK
>   /x86_64/usb/hcd/pci/uhci-hotplug:                                    OK
>   /x86_64/usb/hcd/pci/ehci-hotplug:                                    OK
>   /x86_64/usb/hcd/pci/xhci-hotplug:                                    OK
> PASS: tests/usb-hcd-hotplug-test
> TEST: tests/qom-test... (pid=20068)
>   /x86_64/qom/pc-i440fx-1.4:                                           OK
>   /x86_64/qom/pc-1.3:                                                  OK
>   /x86_64/qom/pc-0.11:                                                 OK
>  [...]
> 
> Best regards,
> -Gonglei
> 
> Gonglei (4):
>   tests: add OHCI qtest
>   tests: add UHCI qtest
>   tests: add xHCI qtest
>   tests: add usb hcds hotplugging qtest
> 
>  MAINTAINERS                  |  2 +-
>  tests/Makefile               | 12 +++++-
>  tests/usb-hcd-hotplug-test.c | 88 ++++++++++++++++++++++++++++++++++++++++++++
>  tests/usb-hcd-ohci-test.c    | 35 ++++++++++++++++++
>  tests/usb-hcd-uhci-test.c    | 35 ++++++++++++++++++
>  tests/usb-hcd-xhci-test.c    | 35 ++++++++++++++++++
>  6 files changed, 205 insertions(+), 2 deletions(-)
>  create mode 100644 tests/usb-hcd-hotplug-test.c
>  create mode 100644 tests/usb-hcd-ohci-test.c
>  create mode 100644 tests/usb-hcd-uhci-test.c
>  create mode 100644 tests/usb-hcd-xhci-test.c
> 
> -- 
> 1.7.12.4
> 

-- 
			Amos.