From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzoaM-0000K5-O9 for qemu-devel@nongnu.org; Wed, 25 Jun 2014 10:54:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzoaF-0000ie-A6 for qemu-devel@nongnu.org; Wed, 25 Jun 2014 10:54:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzoaF-0000hz-0F for qemu-devel@nongnu.org; Wed, 25 Jun 2014 10:53:59 -0400 Date: Wed, 25 Jun 2014 16:53:45 +0200 From: Igor Mammedov Message-ID: <20140625165345.62c04ba2@nial.usersys.redhat.com> In-Reply-To: <1403706420-20109-2-git-send-email-mjrosato@linux.vnet.ibm.com> References: <1403706420-20109-1-git-send-email-mjrosato@linux.vnet.ibm.com> <1403706420-20109-2-git-send-email-mjrosato@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 1/3] sclp-s390: Add device to manage s390 memory hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Matthew Rosato Cc: qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, aliguori@amazon.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, rth@twiddle.net On Wed, 25 Jun 2014 10:26:58 -0400 Matthew Rosato wrote: > Add sclpMemoryHotplugDev to contain associated data structures, etc. > > Signed-off-by: Matthew Rosato > --- > hw/s390x/sclp.c | 30 ++++++++++++++++++++++++++++++ > include/hw/s390x/sclp.h | 20 ++++++++++++++++++++ > 2 files changed, 50 insertions(+) > > diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c > index d8ddf35..769d7c3 100644 > --- a/hw/s390x/sclp.c > +++ b/hw/s390x/sclp.c > @@ -183,3 +183,33 @@ void s390_sclp_init(void) > OBJECT(dev), NULL); > qdev_init_nofail(dev); > } > + > +sclpMemoryHotplugDev *init_sclp_memory_hotplug_dev(void) > +{ > + DeviceState *dev; > + dev = qdev_create(NULL, TYPE_SCLP_MEMORY_HOTPLUG_DEV); > + object_property_add_child(qdev_get_machine(), > + TYPE_SCLP_MEMORY_HOTPLUG_DEV, > + OBJECT(dev), NULL); > + qdev_init_nofail(dev); > + return SCLP_MEMORY_HOTPLUG_DEV(object_resolve_path( > + TYPE_SCLP_MEMORY_HOTPLUG_DEV, NULL)); > +} > + > +sclpMemoryHotplugDev *get_sclp_memory_hotplug_dev(void) > +{ > + return SCLP_MEMORY_HOTPLUG_DEV(object_resolve_path( > + TYPE_SCLP_MEMORY_HOTPLUG_DEV, NULL)); > +} > + > +static TypeInfo sclp_memory_hotplug_dev_info = { > + .name = TYPE_SCLP_MEMORY_HOTPLUG_DEV, > + .parent = TYPE_SYS_BUS_DEVICE, > + .instance_size = sizeof(sclpMemoryHotplugDev), Either parent above should be TYPE_DEVICE or s/DeviceState/SysBusDevice/ below > +struct sclpMemoryHotplugDev { > + DeviceState parent;