Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR

[Luiz Capitulino <lcapitulino@redhat.com>]

On Thu, 26 Jun 2014 17:40:57 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 26/06/2014 17:37, Markus Armbruster ha scritto:
> > Paolo Bonzini <pbonzini@redhat.com> writes:
> > 
> >> From: Wenchao Xia <wenchaoqemu@gmail.com>
> >>
> >> Signed-off-by: Wenchao Xia <wenchaoqemu@gmail.com>
> >> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > 
> > This broke tests/qemu-iotests/041.  Apparently, the BLOCK_JOB_ERROR
> > event changed from
> > 
> >     {'timestamp': {'seconds': 1403796871, 'microseconds': 446502},
> >      'data': {'device': 'drive0',
> 
> -    bdrv_emit_qmp_error_event(job->bs, QEVENT_BLOCK_JOB_ERROR, action, is_read);
> +    qapi_event_send_block_job_error(bdrv_get_device_name(bs),
> 
> Should have been job->bs.

Yeah, patch is underway.

> 
> >               'action': 'ignore',
> >               'operation': 'write'},
> >      'event': 'BLOCK_JOB_ERROR'}
> > 
> > to
> > 
> >     {'timestamp': {'seconds': 1403796674, 'microseconds': 63271},
> >      'data': {'device': '',
> >               'action': 'report',
> 
> I suppose ignore vs. report is just from pasting two different sections?
> 
> Paolo
> 
> >               'operation': 'write'},
> >      'event': 'BLOCK_JOB_ERROR'}
> > 
> > losing the value of device, which breaks qemu-iotests/041's tests of
> > data/device.
> > 
> > Please fix.
> > 
> > 
>