From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54113)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cnanakos@admin.grnet.gr>) id 1X0CJx-0000NS-SX
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 12:14:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cnanakos@admin.grnet.gr>) id 1X0CJm-0007wd-0J
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 12:14:45 -0400
Received: from averel.grnet-hq.admin.grnet.gr ([195.251.29.3]:30863)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cnanakos@admin.grnet.gr>) id 1X0CJl-0007u9-PW
	for qemu-devel@nongnu.org; Thu, 26 Jun 2014 12:14:33 -0400
Date: Thu, 26 Jun 2014 19:14:06 +0300
From: Chrysostomos Nanakos <cnanakos@grnet.gr>
Message-ID: <20140626161406.GA353@apollo.local>
References: <1403526734-29237-1-git-send-email-cnanakos@grnet.gr>
	<1403526734-29237-2-git-send-email-cnanakos@grnet.gr>
	<53AC36DB.8090009@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53AC36DB.8090009@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 1/4] block: Support Archipelago as a
 QEMU block backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Thu, Jun 26, 2014 at 09:06:03AM -0600, Eric Blake wrote:
> On 06/23/2014 06:32 AM, Chrysostomos Nanakos wrote:
> > VM Image on Archipelago volume is specified like this:
> > 
> > file=archipelago:<volumename>[/mport=<mapperd_port>[:vport=<vlmcd_port>][:
> > segment=<segment_name>]]
> > 
> > or
> > 
> > file.driver=archipelago,file.volume=<volumename>[,file.mport=<mapperd_port>[,
> > file.vport=<vlmcd_port>][,file.segment=<segment_name>]]
> > 
> 
> I still plan to review this series in full, but my quick pre-review comment:
> 
> on version 2, Markus suggested that you should separate the patch that
> adds QMP structured options (first) from the patch that adds syntactic
> sugar
> file=archipelago:<volumename>[/mport=<mapperd_port>[:vport=<vlmcd_port>]] (second)
> 
> https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00269.html
> 
> and I stand by his suggestion, although I don't see that split here yet.
> 
A new patch series (v6) will be submitted ASAP, splitting QMP structured options and
syntactic sugar as suggested.

Thanks!