From: Kevin Wolf <kwolf@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: benoit.canet@irqsave.net, famz@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH for 2.1 0/2] Fix commit of oversized layer
Date: Fri, 27 Jun 2014 11:44:49 +0200 [thread overview]
Message-ID: <20140627094449.GB5223@noname.redhat.com> (raw)
In-Reply-To: <cover.1403729574.git.jcody@redhat.com>
Am 25.06.2014 um 22:55 hat Jeff Cody geschrieben:
> This fixes a regression in block-commit; if the top image is larger than the
> base image, we attempt to resize the base image. The regression is that we
> fail the image truncate operation, returning -EBUSY.
Thanks, applied to the block branch.
One thing I'm not sure about is whether commit (all of synchronous,
live and live on active layer) should check the RESIZE blocker before
resizing the backing file.
In general, it feels like it would be the right thing to do, especially
considering the goal of operation categories in the final state, but on
the other hand it means that RESIZE would have to be excluded from
bs->backing_blocker, too, allowing standalone resize commands on backing
files. Not sure that this would be a good idea...
Kevin
next prev parent reply other threads:[~2014-06-27 9:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 20:55 [Qemu-devel] [PATCH for 2.1 0/2] Fix commit of oversized layer Jeff Cody
2014-06-25 20:55 ` [Qemu-devel] [PATCH for 2.1 1/2] block: check for RESIZE blocker in the QMP command, not bdrv_truncate() Jeff Cody
2014-06-25 20:55 ` [Qemu-devel] [PATCH for 2.1 2/2] block: add qemu-iotest for resize base during live commit Jeff Cody
2014-06-25 22:08 ` [Qemu-devel] [PATCH for 2.1 0/2] Fix commit of oversized layer Eric Blake
2014-06-27 9:44 ` Kevin Wolf [this message]
2014-07-10 8:42 ` Fam Zheng
2014-07-10 9:25 ` Kevin Wolf
2014-07-10 9:48 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140627094449.GB5223@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).