From: Stefan Hajnoczi <stefanha@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2] hw/net/eepro100: Implement read-only bits in MDI registers
Date: Fri, 27 Jun 2014 12:25:22 +0200 [thread overview]
Message-ID: <20140627102522.GK12061@stefanha-thinkpad.muc.redhat.com> (raw)
In-Reply-To: <1402326188-23869-1-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 895 bytes --]
On Mon, Jun 09, 2014 at 04:03:08PM +0100, Peter Maydell wrote:
> Although we defined an eepro100_mdi_mask[] array indicating which bits
> in the registers are read-only, we weren't actually doing anything with
> it. Make the MDI register-write code use it rather than manually making
> register 1 read-only and leaving the rest as reads-as-written. (The
> special-case handling of register 0 remains as before since its mask is
> all-zeros and the special casing happens before we apply the masking.)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Message-id: 1402159924-13853-1-git-send-email-peter.maydell@linaro.org
> ---
> No code change, but I fixed the errors in the commit message.
>
> hw/net/eepro100.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-06-27 10:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 15:03 [Qemu-devel] [PATCH v2] hw/net/eepro100: Implement read-only bits in MDI registers Peter Maydell
2014-06-23 22:36 ` Peter Maydell
2014-06-27 10:25 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140627102522.GK12061@stefanha-thinkpad.muc.redhat.com \
--to=stefanha@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).