From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0TLW-0001Tn-SV for qemu-devel@nongnu.org; Fri, 27 Jun 2014 06:25:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0TLS-00063o-Jg for qemu-devel@nongnu.org; Fri, 27 Jun 2014 06:25:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0TLS-00063e-Bc for qemu-devel@nongnu.org; Fri, 27 Jun 2014 06:25:26 -0400 Date: Fri, 27 Jun 2014 12:25:22 +0200 From: Stefan Hajnoczi Message-ID: <20140627102522.GK12061@stefanha-thinkpad.muc.redhat.com> References: <1402326188-23869-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HTLCc13+3hfAZ6SL" Content-Disposition: inline In-Reply-To: <1402326188-23869-1-git-send-email-peter.maydell@linaro.org> Subject: Re: [Qemu-devel] [PATCH v2] hw/net/eepro100: Implement read-only bits in MDI registers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org --HTLCc13+3hfAZ6SL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 09, 2014 at 04:03:08PM +0100, Peter Maydell wrote: > Although we defined an eepro100_mdi_mask[] array indicating which bits > in the registers are read-only, we weren't actually doing anything with > it. Make the MDI register-write code use it rather than manually making > register 1 read-only and leaving the rest as reads-as-written. (The > special-case handling of register 0 remains as before since its mask is > all-zeros and the special casing happens before we apply the masking.) >=20 > Signed-off-by: Peter Maydell > Message-id: 1402159924-13853-1-git-send-email-peter.maydell@linaro.org > --- > No code change, but I fixed the errors in the commit message. >=20 > hw/net/eepro100.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan --HTLCc13+3hfAZ6SL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTrUaSAAoJEJykq7OBq3PI2esH/jujO7b8Y0i/ckQam44mfk6b /gB6pC6ld0WHV0CapMGiM6H+TOcMMISWo/EmKYBbScP75aPd6Yz4ld1oD7oSkS+9 fBpCC7b165Cw5kpTx1V9Hq8AOPvMOj4l0VJ3JJMbBnAEIi7hLbmXszQTNrNYdUGQ PkBT0WsCYDhkZip7A4qAxcBp01j46ZBvzNRqYy/+sYd9q2InZRWXJMHFdr2geJLL 7FkykEE18r0VtsOLiiGDHwWxquXjalhBhZxGpte8c4M33gl+LVMDXCekfNZKq13T 5WCkCAeJC8YaEd3iRimiTqYxGGem0JFH41OIqOUWhDiZjIQWS02yocA32rX/iho= =jwTT -----END PGP SIGNATURE----- --HTLCc13+3hfAZ6SL--