From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51164)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1X0afC-0007XE-Da
	for qemu-devel@nongnu.org; Fri, 27 Jun 2014 14:14:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1X0af4-0005As-TC
	for qemu-devel@nongnu.org; Fri, 27 Jun 2014 14:14:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60636)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1X0af4-0005An-KC
	for qemu-devel@nongnu.org; Fri, 27 Jun 2014 14:14:10 -0400
Date: Fri, 27 Jun 2014 12:42:30 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20140627124230.39158b7d@redhat.com>
In-Reply-To: <20140627162847.GJ5223@noname.redhat.com>
References: <1403876842-15926-1-git-send-email-armbru@redhat.com>
	<1403876842-15926-2-git-send-email-armbru@redhat.com>
	<20140627162847.GJ5223@noname.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2.1 1/2] blockjob: Fix recent
	BLOCK_JOB_READY regression
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: wenchaoqemu@gmail.com, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com

On Fri, 27 Jun 2014 18:28:47 +0200
Kevin Wolf <kwolf@redhat.com> wrote:

> Am 27.06.2014 um 15:47 hat Markus Armbruster geschrieben:
> > Commit bcada37 dropped the (undocumented) members type, len, offset,
> > speed, breaking tests/qemu-iotests/040 and 041.
> > 
> > Restore them.  This fixes 040, and partially fixes 041.
> > 
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> > ---
> >  blockjob.c           | 6 +++++-
> >  qapi/block-core.json | 6 +++++-
> >  2 files changed, 10 insertions(+), 2 deletions(-)
> > 
> > diff --git a/blockjob.c b/blockjob.c
> > index 4da86cd..37a8f1f 100644
> > --- a/blockjob.c
> > +++ b/blockjob.c
> > @@ -256,7 +256,11 @@ void block_job_event_completed(BlockJob *job, const char *msg)
> >  
> >  void block_job_event_ready(BlockJob *job)
> >  {
> > -    qapi_event_send_block_job_ready(bdrv_get_device_name(job->bs), &error_abort);
> > +    qapi_event_send_block_job_ready(job->driver->job_type,
> > +                                    bdrv_get_device_name(job->bs),
> > +                                    job->len,
> > +                                    job->offset,
> > +                                    job->speed, &error_abort);
> >  }
> >  
> >  BlockErrorAction block_job_error_action(BlockJob *job, BlockDriverState *bs,
> > diff --git a/qapi/block-core.json b/qapi/block-core.json
> > index af6b436..8f42f24 100644
> > --- a/qapi/block-core.json
> > +++ b/qapi/block-core.json
> > @@ -1559,4 +1559,8 @@
> >  # Since: 1.3
> >  ##
> >  { 'event': 'BLOCK_JOB_READY',
> > -  'data': { 'device': 'str' } }
> > +  'data': { 'type'  : 'BlockJobType',
> > +            'device': 'str',
> > +            'len'   : 'int',
> > +            'offset': 'int',
> > +            'speed' : 'int' } }
> 
> Please document the added fields in the comment above the definition.

We have to add them to docs/qmp/qmp-events.txt too.

Markus, you can add a diff in this thread and I'll squash it with the patch.