From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0WDJ-0008VF-FG for qemu-devel@nongnu.org; Fri, 27 Jun 2014 09:29:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0WDC-0007sZ-SQ for qemu-devel@nongnu.org; Fri, 27 Jun 2014 09:29:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0WDC-0007s2-KC for qemu-devel@nongnu.org; Fri, 27 Jun 2014 09:29:06 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5RDT55x021676 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 27 Jun 2014 09:29:05 -0400 Date: Fri, 27 Jun 2014 15:29:04 +0200 From: Stefan Hajnoczi Message-ID: <20140627132904.GA31358@stefanha-thinkpad.muc.redhat.com> References: <1402459910-18889-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IJpNTDwzlM2Ie8A6" Content-Disposition: inline In-Reply-To: <1402459910-18889-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , Paolo Bonzini , qemu-devel@nongnu.org --IJpNTDwzlM2Ie8A6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 11, 2014 at 12:11:41PM +0800, Fam Zheng wrote: > This unifies the request structure used by dataplane and non-dataplane co= de, > while dropping unnessary fields for bounce buffer and read flag. >=20 > v4: Address Stefan's comments as below, and add Paolo's rev-by lines to o= thers. >=20 > [01/09] virtio-blk: Move VirtIOBlockReq to header >=20 > Include "block/block.h". >=20 > [02/09] virtio-blk: Convert VirtIOBlockReq.elem to pointer >=20 > Use g_slice_new0 for req as well. >=20 > [06/09] virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr >=20 > Check guest input, don't assert. >=20 > [09/09] virtio-blk: Fix and clean up the in_sg and out_sg check >=20 > Use error_report + exit. >=20 > Fam Zheng (9): > virtio-blk: Move VirtIOBlockReq to header > virtio-blk: Convert VirtIOBlockReq.elem to pointer > virtio-blk: Drop bounce buffer from dataplane code > virtio-blk: Drop VirtIOBlockRequest.read > virtio-blk: Replace VirtIOBlockRequest with VirtIOBlockReq > virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr > virtio-blk: Convert VirtIOBlockReq.out to structrue > virtio-blk: Fill in VirtIOBlockReq.out in dataplane code > virtio-blk: Fix and clean up the in_sg and out_sg check >=20 > hw/block/dataplane/virtio-blk.c | 169 ++++++++++++++--------------------= ------ > hw/block/virtio-blk.c | 117 +++++++++++++++------------- > include/hw/virtio/virtio-blk.h | 11 +++ > 3 files changed, 132 insertions(+), 165 deletions(-) >=20 > --=20 > 2.0.0 >=20 Reviewed-by: Stefan Hajnoczi --IJpNTDwzlM2Ie8A6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTrXGgAAoJEJykq7OBq3PIJYQH/1+rWQ8RB70B73lwfX8O7m3+ KQ/+tteHlKU9IaZStTXcUeOJ2RVzGkaBNOiIeilmQ93dMaW2z/DVVHPXAiYNls/P w707SqLl80LiDJSVP1191NfKrAtBMDZTjFp1Sa3NZfU0yjSoSwQs2ZY1Rn7SPfnE nD+QtgaBUwNErjqfIzRxY5+DuagymepHZ9IhIJm6OS8ovDRFZBpJ+WjJhY4IXKLz 0PxNBtNb3RwedCcUBt3X49pQ6B/ZNp1u6a2hawQFrrybt/QS4IknkTgN+YBJ2L4f ntgQW1OGAA0R0qG/jx4I7Gl0lEC1q37j+SyQA2ZkWPu+vOpNzcktlPVlmQmGMP0= =g8Xx -----END PGP SIGNATURE----- --IJpNTDwzlM2Ie8A6--