From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46095)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1X0WEk-000254-KL
	for qemu-devel@nongnu.org; Fri, 27 Jun 2014 09:30:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1X0WEe-0008UY-GH
	for qemu-devel@nongnu.org; Fri, 27 Jun 2014 09:30:42 -0400
Received: from afflict.kos.to ([92.243.29.197]:53895)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nchip@afflict.kos.to>) id 1X0WEe-0008UT-4O
	for qemu-devel@nongnu.org; Fri, 27 Jun 2014 09:30:36 -0400
Date: Fri, 27 Jun 2014 16:30:34 +0300
From: Riku Voipio <riku.voipio@iki.fi>
Message-ID: <20140627133034.GB17562@afflict.kos.to>
References: <1403391191-18603-1-git-send-email-paul@archlinuxmips.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1403391191-18603-1-git-send-email-paul@archlinuxmips.org>
Subject: Re: [Qemu-devel] [PATCH v2 00/16] linux-user fixes & improvements
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Burton <paul@archlinuxmips.org>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org, Paul Burton <paul.burton@imgtec.com>

On Sat, Jun 21, 2014 at 11:52:55PM +0100, Paul Burton wrote:
> From: Paul Burton <paul.burton@imgtec.com>
> 
> This series fixes a number of bugs in QEMUs linux-user support, some
> specific to targetting the MIPS architecture but mostly generic. It also
> adds support for some previously unsupported syscalls & {g,s}etsockopt
> options.

Looks mostly good - unfortunately I missed some issues last round. 
iI gave comments to the {name_to,open_by}_handle_at patch - which also
caused the build error for Peter.

Also, compile test on older distro showed that new syscalls need both
target and host test:

#ifdef TARGET_NR_setns

needs to be replaced with

#if defined(TARGET_NR_setns) && defined(__NR_setns) 

Riku

> Paul Burton (16):
>   linux-user: translate the result of getsockopt SO_TYPE
>   linux-user: support SO_ACCEPTCONN getsockopt option
>   linux-user: support SO_{SND,RCV}BUFFORCE setsockopt options
>   linux-user: support SO_PASSSEC setsockopt option
>   linux-user: allow NULL arguments to mount
>   linux-user: support strace of epoll_create1
>   linux-user: fix struct target_epoll_event layout for MIPS
>   linux-user: respect timezone for settimeofday
>   linux-user: allow NULL tv argument for settimeofday
>   linux-user: support timerfd_{create,gettime,settime} syscalls
>   linux-user: support ioprio_{get,set} syscalls
>   linux-user: support {name_to,open_by}_handle_at syscalls
>   linux-user: support the setns syscall
>   linux-user: support the unshare syscall
>   linux-user: support the KDSIGACCEPT ioctl
>   linux-user: support the SIOCGIFINDEX ioctl
> 
>  linux-user/ioctls.h       |   2 +
>  linux-user/socket.h       |   5 +
>  linux-user/strace.c       |  30 +++++
>  linux-user/strace.list    |  21 ++++
>  linux-user/syscall.c      | 271 +++++++++++++++++++++++++++++++++++++++++-----
>  linux-user/syscall_defs.h |   9 +-
>  6 files changed, 311 insertions(+), 27 deletions(-)
> 
> -- 
> 2.0.0