From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0af1-0007Rt-U7 for qemu-devel@nongnu.org; Fri, 27 Jun 2014 14:14:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0aev-0005AB-Pw for qemu-devel@nongnu.org; Fri, 27 Jun 2014 14:14:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0aev-0005A6-Gv for qemu-devel@nongnu.org; Fri, 27 Jun 2014 14:14:01 -0400 Date: Fri, 27 Jun 2014 13:42:07 -0400 From: Luiz Capitulino Message-ID: <20140627134207.20c84306@redhat.com> In-Reply-To: <1403889855-5740-4-git-send-email-armbru@redhat.com> References: <1403889855-5740-1-git-send-email-armbru@redhat.com> <1403889855-5740-4-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2.1 3/3] docs/qmp: Fix documentation of BLOCK_JOB_READY to match code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, wenchaoqemu@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com On Fri, 27 Jun 2014 19:24:15 +0200 Markus Armbruster wrote: > Signed-off-by: Markus Armbruster I've cherry picked this one as this file only exists in qmp tree. > --- > docs/qmp/qmp-events.txt | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt > index 22fea58..44be891 100644 > --- a/docs/qmp/qmp-events.txt > +++ b/docs/qmp/qmp-events.txt > @@ -157,12 +157,20 @@ Emitted when a block job is ready to complete. > > Data: > > -- "device": device name (json-string) > +- "type": Job type (json-string; "stream" for image streaming > + "commit" for block commit) > +- "device": Device name (json-string) > +- "len": Maximum progress value (json-int) > +- "offset": Current progress value (json-int) > + On success this is equal to len. > + On failure this is less than len. > +- "speed": Rate limit, bytes per second (json-int) > > Example: > > { "event": "BLOCK_JOB_READY", > - "data": { "device": "ide0-hd1" }, > + "data": { "device": "drive0", "type": "mirror", "speed": 0, > + "len": 2097152, "offset": 2097152 } > "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } > > Note: The "ready to complete" status is always reset by a BLOCK_JOB_ERROR