From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0Yby-0005nM-Dj for qemu-devel@nongnu.org; Fri, 27 Jun 2014 12:02:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0Ybq-0002Ne-Om for qemu-devel@nongnu.org; Fri, 27 Jun 2014 12:02:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0Ybq-0002NO-Fc for qemu-devel@nongnu.org; Fri, 27 Jun 2014 12:02:42 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5RG2fE4015304 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 27 Jun 2014 12:02:41 -0400 Date: Fri, 27 Jun 2014 18:01:09 +0200 From: Stefan Hajnoczi Message-ID: <20140627160109.GB31358@stefanha-thinkpad.muc.redhat.com> References: <1402986730-25642-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+pHx0qQiF2pBVqBT" Content-Disposition: inline In-Reply-To: <1402986730-25642-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/7] virtio-blk: Unify request handling of dataplane List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , Paolo Bonzini , qemu-devel@nongnu.org --+pHx0qQiF2pBVqBT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 17, 2014 at 02:32:03PM +0800, Fam Zheng wrote: > v2: Address Paolo's comments: >=20 > * Schedule restart BH in the right AioContext. > * Restore ->complete_request when stopping dataplane. =20 >=20 > This is based on top of my request converging series: >=20 > [PATCH v4 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq >=20 > Most of the request handlings are already the same now between dataplane = and > non-dataplane, except the missing IO accounting, error reporting and > multiwrite. With this series, dataplane pulls in all of them by reusing > non-dataplane handling code. >=20 > Thread safety of error reporting relies on Paolo's series: >=20 > [PATCH 0/5] qemu-char/monitor: make monitor_puts thread safe >=20 > [PATCH v2 0/2] block: thread-safety patches for virtio-blk dataplane > rerror/werror >=20 > Fam Zheng (5): > virtio-blk: Make request completion function virtual > virtio-blk: Export request handling functions to dataplane > virtio-blk: Schedule BH in the right context > virtio-blk: Unify {non-,}dataplane's request handlings > virtio-blk: Rename complete_request_early to complete_request_vring >=20 > Stefan Hajnoczi (2): > block: make bdrv_query_stats() static > block: acquire AioContext in qmp_query_blockstats() >=20 > block/qapi.c | 6 +- > hw/block/dataplane/virtio-blk.c | 185 +++++-----------------------------= ------ > hw/block/virtio-blk.c | 22 ++--- > include/block/qapi.h | 1 - > include/hw/virtio/virtio-blk.h | 12 +++ > 5 files changed, 49 insertions(+), 177 deletions(-) >=20 > --=20 > 2.0.0 >=20 Reviewed-by: Stefan Hajnoczi --+pHx0qQiF2pBVqBT Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTrZVFAAoJEJykq7OBq3PISfoIAKzNq1KMHSqPdd8S8JXPFx39 +Reph5Kt4pbZaze3n/beUJNPDQxjVZk5H+cVOM5WzBmyGzhjoqHXGYmY5Gg1G1eN wn7GzTzvJ4RbtReMDTSSKcUg1afaHNrJItasWqJaCbMxiMEerQQgqN0W0eB/QAMA xXJ1t0RbH6TnLa+hcozHPCIUXR+DwhKcxvPaasFmJPTaDXwV3ct+v1yD8k3EaDVA S4qSPy2FXZBoJ5vGnqDVhCgun1YGA8m5kMPBM7E7ebCXwkK+eRWmSo8CHLUyHIXS 18Cnia17DJKOaAe/SCSj15y86aUjToS7sixxqgP4SQUfiLwglMniWvNMrmKyGlk= =3m81 -----END PGP SIGNATURE----- --+pHx0qQiF2pBVqBT--