From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0Yu4-0006zX-TV for qemu-devel@nongnu.org; Fri, 27 Jun 2014 12:21:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0Ytx-0001Hi-UU for qemu-devel@nongnu.org; Fri, 27 Jun 2014 12:21:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0Ytx-0001Gj-Ls for qemu-devel@nongnu.org; Fri, 27 Jun 2014 12:21:25 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5RGLOhC031083 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 27 Jun 2014 12:21:25 -0400 Date: Fri, 27 Jun 2014 18:21:22 +0200 From: Kevin Wolf Message-ID: <20140627162122.GI5223@noname.redhat.com> References: <1402986730-25642-1-git-send-email-famz@redhat.com> <20140627160109.GB31358@stefanha-thinkpad.muc.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LwW0XdcUbUexiWVK" Content-Disposition: inline In-Reply-To: <20140627160109.GB31358@stefanha-thinkpad.muc.redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/7] virtio-blk: Unify request handling of dataplane List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Paolo Bonzini , Fam Zheng , qemu-devel@nongnu.org --LwW0XdcUbUexiWVK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 27.06.2014 um 18:01 hat Stefan Hajnoczi geschrieben: > On Tue, Jun 17, 2014 at 02:32:03PM +0800, Fam Zheng wrote: > > v2: Address Paolo's comments: > >=20 > > * Schedule restart BH in the right AioContext. > > * Restore ->complete_request when stopping dataplane. =20 > >=20 > > This is based on top of my request converging series: > >=20 > > [PATCH v4 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlock= Req > >=20 > > Most of the request handlings are already the same now between dataplan= e and > > non-dataplane, except the missing IO accounting, error reporting and > > multiwrite. With this series, dataplane pulls in all of them by reusing > > non-dataplane handling code. > >=20 > > Thread safety of error reporting relies on Paolo's series: > >=20 > > [PATCH 0/5] qemu-char/monitor: make monitor_puts thread safe > >=20 > > [PATCH v2 0/2] block: thread-safety patches for virtio-blk dataplane > > rerror/werror > >=20 > > Fam Zheng (5): > > virtio-blk: Make request completion function virtual > > virtio-blk: Export request handling functions to dataplane > > virtio-blk: Schedule BH in the right context > > virtio-blk: Unify {non-,}dataplane's request handlings > > virtio-blk: Rename complete_request_early to complete_request_vring > >=20 > > Stefan Hajnoczi (2): > > block: make bdrv_query_stats() static > > block: acquire AioContext in qmp_query_blockstats() > >=20 > > block/qapi.c | 6 +- > > hw/block/dataplane/virtio-blk.c | 185 +++++---------------------------= -------- > > hw/block/virtio-blk.c | 22 ++--- > > include/block/qapi.h | 1 - > > include/hw/virtio/virtio-blk.h | 12 +++ > > 5 files changed, 49 insertions(+), 177 deletions(-) > >=20 > > --=20 > > 2.0.0 > >=20 >=20 > Reviewed-by: Stefan Hajnoczi Thanks, applied all to the block branch. Kevin --LwW0XdcUbUexiWVK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTrZoCAAoJEH8JsnLIjy/WDOgP+wTSXEsJ/7F+9DKU18MB39Lv AQb4RwQmUnRNgmaitLzaWTLNtpkcQ+AUYOCeTPIUQaJkTOqN4natHDEgY9GiLyj5 Gw7tSRiv/7CUiOh5TablpHO4MHb2dwAWIfIUAdxo0dN1WlEf7us+OViFtjRBisfg kouRG0fVyUGF9fB/6FoxUUbmNuBvW811p2jlmkTM84L7rSsnvZCq8q79CR7bsPet CkB/ZWZalbq0ZfLVXiKJcQx2R4URp1RjXk1748QhvaBnbRZ0ODLNEWtv334rbUlQ KT1RBmsa7yc0lUOorvKEj99n6cyMYY/UeTdt+jZ1BzFoXCEHNYXrnmv3VcLqtFHC ayrNfQViVdRfNhyn+S+vAm86ICVfPaO9CuhRfwtzAwSvLa/5tXc5r515NTz0iHKU gmnX5nPagvR9yT1gvDE3WP0c0vGohI3uGSHZdPHIaWmvNql5dKaS+kymEByonNt+ 5bsMgfxdVWv8HRFqTLTDzKpSIcZiD47LsxW9aF6S4ZXnrkwtttLijQweOVv2VX7Z IJNFxX/nCWCGoRfarTFY2ZlwY1HPit1XiHCYelAflKCYZ9A5njYT6i1DHuKxDGrU 7m2RzT2T3piEs+c48AFSGJMJQEmAPTQy+RCJLWgbGXl2Cx3lq7IoZyNcguM+kSMo IYoEfsVXfDmQHDAV/nO2 =Mymj -----END PGP SIGNATURE----- --LwW0XdcUbUexiWVK--