From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0XtV-0006TD-SC for qemu-devel@nongnu.org; Fri, 27 Jun 2014 11:17:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0XtM-00039C-Jx for qemu-devel@nongnu.org; Fri, 27 Jun 2014 11:16:53 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:52722) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0XtM-00038h-BA for qemu-devel@nongnu.org; Fri, 27 Jun 2014 11:16:44 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 27 Jun 2014 16:16:42 +0100 Date: Fri, 27 Jun 2014 17:16:32 +0200 From: Greg Kurz Message-ID: <20140627171632.17b0ff18@bahia.local> In-Reply-To: <20140627134737.26170.27909.stgit@nimbus> References: <20140627134737.26170.27909.stgit@nimbus> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-ppc: KVMPPC_H_CAS fix cpu-version endianess List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Dufour Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf On Fri, 27 Jun 2014 15:47:37 +0200 Laurent Dufour wrote: > During KVMPPC_H_CAS processing, the cpu-version updated value is stored > without taking care of the current endianess. As a consequence, the guest > may not switch to the right CPU model, leading to unexpected results. > > If needed, the value is now converted. > > Fixes: 6d9412ea8132 ("target-ppc: Implement "compat" CPU option") > Signed-off-by: Laurent Dufour > --- Reviewed-by: Greg Kurz > hw/ppc/spapr.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 82f183f173ee..85e9f4a74933 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -228,8 +228,7 @@ static int spapr_fixup_cpu_smt_dt(void *fdt, int offset, PowerPCCPU *cpu, > int index = ppc_get_vcpu_dt_id(cpu); > > if (cpu->cpu_version) { > - ret = fdt_setprop(fdt, offset, "cpu-version", > - &cpu->cpu_version, sizeof(cpu->cpu_version)); > + ret = fdt_setprop_cell(fdt, offset, "cpu-version", cpu->cpu_version); > if (ret < 0) { > return ret; > } > > -- Gregory Kurz kurzgreg@fr.ibm.com gkurz@linux.vnet.ibm.com Software Engineer @ IBM/Meiosys http://www.ibm.com Tel +33 (0)562 165 496 "Anarchy is about taking complete responsibility for yourself." Alan Moore.