Re: [Qemu-devel] [PULL 0/5] NBD changes for 2014-06-27

[Hani Benhabiles <kroosec@gmail.com>]

On Sun, Jun 29, 2014 at 12:45:27PM +0100, Peter Maydell wrote:
> On 27 June 2014 15:11, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > The following changes since commit d4cba13bdf251baeedb36b87c1e9f6766773e380:
> >
> >   tcg/ppc: Fix failure in tcg_out_mem_long (2014-06-27 13:23:41 +0100)
> >
> > are available in the git repository at:
> >
> >   git://github.com/bonzini/qemu.git nbd-next
> >
> > for you to fetch changes up to 34bf23a5e0e878e3cd650c47d670b881f9f61475:
> >
> >   nbd: Handle NBD_OPT_LIST option. (2014-06-27 16:06:48 +0200)
> >
> > Three bugfixes, and a new feature.
> 
> Hi. I'm afraid this doesn't build on win32:

Hi Peter,

Should be fixed with s/SHUT_RDWR/2/

That is how shutdown() is called elsewhere in nbd.c and block/nbd-client.c

> /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c: In function ‘nbd_accept’:
> /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c:31: error:
> ‘SHUT_RDWR’ undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c:31: error: (Each
> undeclared identifier is reported only once
> /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c:31: error: for
> each function it appears in.)
> make: *** [blockdev-nbd.o] Error 1
> 
> thanks
> -- PMM
>