From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44919)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kroosec@gmail.com>) id 1X1Dhc-000075-P1
	for qemu-devel@nongnu.org; Sun, 29 Jun 2014 07:55:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kroosec@gmail.com>) id 1X1DhX-0003ps-3F
	for qemu-devel@nongnu.org; Sun, 29 Jun 2014 07:55:24 -0400
Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:49274)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kroosec@gmail.com>) id 1X1DhW-0003ph-Ta
	for qemu-devel@nongnu.org; Sun, 29 Jun 2014 07:55:19 -0400
Received: by mail-we0-f176.google.com with SMTP id u56so6845235wes.21
	for <qemu-devel@nongnu.org>; Sun, 29 Jun 2014 04:55:17 -0700 (PDT)
Date: Sun, 29 Jun 2014 12:55:11 +0100
From: Hani Benhabiles <kroosec@gmail.com>
Message-ID: <20140629115511.GA4612@Inspiron-3521>
References: <1403878306-22683-1-git-send-email-pbonzini@redhat.com>
	<CAFEAcA_4=Nfc6Zo2Bq0hf07f_fjD32D+_FHPLO8USEr_odFR_g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAFEAcA_4=Nfc6Zo2Bq0hf07f_fjD32D+_FHPLO8USEr_odFR_g@mail.gmail.com>
Subject: Re: [Qemu-devel] [PULL 0/5] NBD changes for 2014-06-27
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On Sun, Jun 29, 2014 at 12:45:27PM +0100, Peter Maydell wrote:
> On 27 June 2014 15:11, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > The following changes since commit d4cba13bdf251baeedb36b87c1e9f6766773e380:
> >
> >   tcg/ppc: Fix failure in tcg_out_mem_long (2014-06-27 13:23:41 +0100)
> >
> > are available in the git repository at:
> >
> >   git://github.com/bonzini/qemu.git nbd-next
> >
> > for you to fetch changes up to 34bf23a5e0e878e3cd650c47d670b881f9f61475:
> >
> >   nbd: Handle NBD_OPT_LIST option. (2014-06-27 16:06:48 +0200)
> >
> > Three bugfixes, and a new feature.
> 
> Hi. I'm afraid this doesn't build on win32:

Hi Peter,

Should be fixed with s/SHUT_RDWR/2/

That is how shutdown() is called elsewhere in nbd.c and block/nbd-client.c

> /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c: In function ‘nbd_accept’:
> /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c:31: error:
> ‘SHUT_RDWR’ undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c:31: error: (Each
> undeclared identifier is reported only once
> /home/petmay01/linaro/qemu-for-merges/blockdev-nbd.c:31: error: for
> each function it appears in.)
> make: *** [blockdev-nbd.o] Error 1
> 
> thanks
> -- PMM
>