From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56689)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1X1YVa-0001D5-80
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 06:08:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1X1YVV-0003zK-HI
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 06:08:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:14470)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1X1YVV-0003yt-8f
	for qemu-devel@nongnu.org; Mon, 30 Jun 2014 06:08:17 -0400
Date: Mon, 30 Jun 2014 13:08:38 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140630100838.GA19383@redhat.com>
References: <1401847555-8306-1-git-send-email-ming.lei@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1401847555-8306-1-git-send-email-ming.lei@canonical.com>
Subject: Re: [Qemu-devel] [PATCH] hw/virtio: enable common virtio feature
	for mmio device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ming Lei <ming.lei@canonical.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

On Wed, Jun 04, 2014 at 10:05:55AM +0800, Ming Lei wrote:
> Both 'indirect_desc' and 'event_idx' are bus independent features,
> and they should be enabled for mmio devices too.
> 
> On arm64 quad core VM(qemu-kvm), the patch can increase block I/O
> performance a lot with latest linux tree:
>         - without the patch: 14K IOPS
>         - with the patch: 34K IOPS
>     
> fio script:
>         [global]
>         direct=1
>         bsrange=4k-4k
>         timeout=10
>         numjobs=4
>         ioengine=libaio
>         iodepth=64
>     
>         filename=/dev/vdc
>         group_reporting=1
>     
>         [f1]
>         rw=randread
> 
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Ming Lei <ming.lei@canonical.com>

Applied, thanks!

> ---
>  hw/virtio/virtio-mmio.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c
> index 8829eb0..18c6e5b 100644
> --- a/hw/virtio/virtio-mmio.c
> +++ b/hw/virtio/virtio-mmio.c
> @@ -369,10 +369,16 @@ static void virtio_mmio_realizefn(DeviceState *d, Error **errp)
>      sysbus_init_mmio(sbd, &proxy->iomem);
>  }
>  
> +static Property virtio_mmio_properties[] = {
> +    DEFINE_VIRTIO_COMMON_FEATURES(VirtIOMMIOProxy, host_features),
> +    DEFINE_PROP_END_OF_LIST(),
> +};
> +
>  static void virtio_mmio_class_init(ObjectClass *klass, void *data)
>  {
>      DeviceClass *dc = DEVICE_CLASS(klass);
>  
> +    dc->props = virtio_mmio_properties;
>      dc->realize = virtio_mmio_realizefn;
>      dc->reset = virtio_mmio_reset;
>      set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> -- 
> 1.7.9.5
>