From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1cX0-00058D-TS for qemu-devel@nongnu.org; Mon, 30 Jun 2014 10:26:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1cWt-0007wM-FL for qemu-devel@nongnu.org; Mon, 30 Jun 2014 10:26:06 -0400 Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr ([80.12.84.125]:44547 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1cWt-0007w2-8m for qemu-devel@nongnu.org; Mon, 30 Jun 2014 10:25:59 -0400 Date: Mon, 30 Jun 2014 16:25:47 +0200 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140630142546.GA17885@irqsave.net> References: <1403900236-3087-1-git-send-email-benoit.canet@irqsave.net> <20140630140957.GB10229@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20140630140957.GB10229@stefanha-thinkpad.redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] qemu-iotests: Disable Quorum testing in 041 when Quorum is not builtin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: =?iso-8859-1?Q?Beno=EEt?= Canet , kwolf@redhat.com, qemu-devel@nongnu.org The Monday 30 Jun 2014 =E0 16:09:57 (+0200), Stefan Hajnoczi wrote : > On Fri, Jun 27, 2014 at 10:17:16PM +0200, Beno=EEt Canet wrote: > I think this patch can be boiled down to 2 lines: >=20 > if __name__ =3D=3D '__main__': > + if 'quorum' not in iotests.qemu_img('--help'): > + iotests.notrun('not built with quorum support') > iotests.main(supported_fmts=3D['qcow2', 'qed']) >=20 > What do you think? The detection part could work using qemu_img_pipe. Are we sure that the test won't fail in strange ways like when using skipTest ? If so do you want me to respin this patch with your version ? Best regards Beno=EEt