From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1sUc-00070I-1x for qemu-devel@nongnu.org; Tue, 01 Jul 2014 03:28:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1sUT-00075N-0s for qemu-devel@nongnu.org; Tue, 01 Jul 2014 03:28:41 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:35198) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1sUS-000756-QX for qemu-devel@nongnu.org; Tue, 01 Jul 2014 03:28:32 -0400 Received: by mail-wi0-f180.google.com with SMTP id hi2so7217969wib.13 for ; Tue, 01 Jul 2014 00:28:32 -0700 (PDT) Date: Tue, 1 Jul 2014 09:28:28 +0200 From: Stefan Hajnoczi Message-ID: <20140701072828.GD24571@stefanha-thinkpad.redhat.com> References: <1403900236-3087-1-git-send-email-benoit.canet@irqsave.net> <20140630140957.GB10229@stefanha-thinkpad.redhat.com> <20140630142546.GA17885@irqsave.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xB0nW4MQa6jZONgY" Content-Disposition: inline In-Reply-To: <20140630142546.GA17885@irqsave.net> Subject: Re: [Qemu-devel] [PATCH v2] qemu-iotests: Disable Quorum testing in 041 when Quorum is not builtin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Beno=EEt?= Canet Cc: kwolf@redhat.com, qemu-devel@nongnu.org --xB0nW4MQa6jZONgY Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 30, 2014 at 04:25:47PM +0200, Beno=EEt Canet wrote: > The Monday 30 Jun 2014 =E0 16:09:57 (+0200), Stefan Hajnoczi wrote : > > On Fri, Jun 27, 2014 at 10:17:16PM +0200, Beno=EEt Canet wrote: > > I think this patch can be boiled down to 2 lines: > >=20 > > if __name__ =3D=3D '__main__': > > + if 'quorum' not in iotests.qemu_img('--help'): > > + iotests.notrun('not built with quorum support') > > iotests.main(supported_fmts=3D['qcow2', 'qed']) > >=20 > > What do you think? >=20 > The detection part could work using qemu_img_pipe. You're right, I used the wrong function. We need the stdout. > Are we sure that the test won't fail in strange ways like > when using skipTest ? Not sure what you mean. > If so do you want me to respin this patch with your version ? Yes, please. --xB0nW4MQa6jZONgY Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTsmMcAAoJEJykq7OBq3PI55gIAJXcKCAZJgT8NIDO5iuymdSZ 76DAm5owanmh7T6zMflEKmCoxzid3sfqJyMRJMXbsI/1W3qE2n8prRgsTERdj/Fn R/nlU2NWMPUdm0B+ckKp90Q3/fbDPQISxtX+Ash8Pud/jO6eEsZ79vlJwy8U9Ruv RbkNJnOGTLdI5UB0fq/p2In0zfhGwA1l8YJjCB8cNKvGs1EvjLSZ6Nj3tdiqEVCG Ln9OMh0cx85mP9c8XSSKvIOhbhYtEkHAzQqP6Ldre9r+HmnAJ4770V4KbEJRdIkf 2XYpnXS+MkxP2Uv+LnI3IcywIq5VFkpVKXUKCUdRsYtS1QhhjKaigylYo8lQct4= =KEVD -----END PGP SIGNATURE----- --xB0nW4MQa6jZONgY--