From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1t9g-00006W-Md for qemu-devel@nongnu.org; Tue, 01 Jul 2014 04:11:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1t9a-0007pP-IG for qemu-devel@nongnu.org; Tue, 01 Jul 2014 04:11:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1t9a-0007oK-99 for qemu-devel@nongnu.org; Tue, 01 Jul 2014 04:11:02 -0400 Date: Tue, 1 Jul 2014 10:10:54 +0200 From: Kevin Wolf Message-ID: <20140701081054.GB4587@noname.str.redhat.com> References: <1403900236-3087-1-git-send-email-benoit.canet@irqsave.net> <20140630140957.GB10229@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z" Content-Disposition: inline In-Reply-To: <20140630140957.GB10229@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] qemu-iotests: Disable Quorum testing in 041 when Quorum is not builtin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: =?iso-8859-1?Q?Beno=EEt?= Canet , qemu-devel@nongnu.org, Benoit Canet --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 30.06.2014 um 16:09 hat Stefan Hajnoczi geschrieben: > On Fri, Jun 27, 2014 at 10:17:16PM +0200, Beno=EEt Canet wrote: > I think this patch can be boiled down to 2 lines: >=20 > if __name__ =3D=3D '__main__': > + if 'quorum' not in iotests.qemu_img('--help'): > + iotests.notrun('not built with quorum support') > iotests.main(supported_fmts=3D['qcow2', 'qed']) >=20 > What do you think? That would disable the whole test case 041, whereas Beno=EEt's patch only disables the quorum-related part. (The test case is really about migration, not only quorum.) Kevin --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTsm0OAAoJEH8JsnLIjy/W8dQQAJiLs9vasZ67GNNo7P5Hiw1M 3Y+wuxZenNFBM8RiM4nyx7ch9XHuTc0SkQZBgEd4J0pTavp9lQ9dTD911yWAbO8U tyJF/159DP2qd4cC+YIYNwoKtgk9r4nW0X4jeFdGcim1WDFtiGBg8kw6hicdYpdY m4ih79k2XXkHZFNSin0TOtwq8E0UvQ7bAqjdzNXRj2601dNdN7b2xSYm9fTsfpSl GJHj8OsTJZp5Go6lSmsbdHbbjn+Lvk6AaNlQFOtv9JI1ESLU5smuPbLLduQtyKTL hw6pL9HALwquGbk93tsXuxjieh+j4iq5bHfwFc1l9cTO3cG3kNffRHOj5h6a63CN 18eqKu1wCmT+7OAOh83wFZgsEF/47XoaExEpKPwmzEWsVtVq2OuBcoW4a/fOxrB/ yo0Whhof+530I3iCo61NMQDzXJgnQMCb6sVnd312BYl3emko3GZQNfJFdehHky1C JYKn4MOh3NSvaZ3dbPVRgBE9vZDGrGn/4sSMRemaJJ8DVzHDX6Wr2wnNRVYMY6RY 18QS79hnj6D0ert/nK63xYvNi00rELUwegp2pMUPb31hApbvhm4Q5UcebzIREkoW 6vYmcfNQv1P2XR5IjimkgI4D4zrHLl9so+ugDLOgfl5XbFsW5H9/knjmVM+3XjnL VBv9blJkB/irj2LbH03E =NNeP -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z--