From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/3] block: Use g_new() & friends more
Date: Tue, 1 Jul 2014 12:14:06 +0200 [thread overview]
Message-ID: <20140701101406.GD4587@noname.str.redhat.com> (raw)
In-Reply-To: <87a98tv468.fsf@blackfin.pond.sub.org>
Am 01.07.2014 um 11:06 hat Markus Armbruster geschrieben:
> Markus Armbruster <armbru@redhat.com> writes:
>
> > This series is on top of Kevin's "block: Handle failure for
> > potentially large allocations".
> >
> > PATCH 1+2 convert some allocations. While preparing them, I stumbled
> > over some useless casts, which led to PATCH 3.
>
> Fell through the cracks despite Max's R-by, and now it doesn't apply
> anymore. Pity, because it improves type safety and reduces
> vulnerability to integer overflows.
Whoops. Not sure if Stefan had any reasons not to merge it (the tree was
his for three weeks because I was away in mine), but it probably really
just fell through the cracks.
> Is this change wanted? Unless I get a "yes" from a maintainer, I'll
> drop it.
Yes, I think it's a good change.
Kevin
next prev parent reply other threads:[~2014-07-01 10:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1401467438-17189-1-git-send-email-armbru@redhat.com>
[not found] ` <1401467438-17189-4-git-send-email-armbru@redhat.com>
[not found] ` <5388CEC7.9010607@redhat.com>
2014-06-02 5:25 ` [Qemu-devel] [PATCH 3/3] block: Drop some superfluous casts from void * Markus Armbruster
2014-07-01 9:06 ` [Qemu-devel] [PATCH 0/3] block: Use g_new() & friends more Markus Armbruster
2014-07-01 10:14 ` Kevin Wolf [this message]
2014-07-01 10:57 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701101406.GD4587@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).