From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1v4l-0000op-6F for qemu-devel@nongnu.org; Tue, 01 Jul 2014 06:14:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1v4j-0002hN-RY for qemu-devel@nongnu.org; Tue, 01 Jul 2014 06:14:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1v4j-0002hF-JY for qemu-devel@nongnu.org; Tue, 01 Jul 2014 06:14:09 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s61AE8Kr023145 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 1 Jul 2014 06:14:08 -0400 Date: Tue, 1 Jul 2014 12:14:06 +0200 From: Kevin Wolf Message-ID: <20140701101406.GD4587@noname.str.redhat.com> References: <1401467438-17189-1-git-send-email-armbru@redhat.com> <87a98tv468.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a98tv468.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH 0/3] block: Use g_new() & friends more List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, stefanha@redhat.com Am 01.07.2014 um 11:06 hat Markus Armbruster geschrieben: > Markus Armbruster writes: > > > This series is on top of Kevin's "block: Handle failure for > > potentially large allocations". > > > > PATCH 1+2 convert some allocations. While preparing them, I stumbled > > over some useless casts, which led to PATCH 3. > > Fell through the cracks despite Max's R-by, and now it doesn't apply > anymore. Pity, because it improves type safety and reduces > vulnerability to integer overflows. Whoops. Not sure if Stefan had any reasons not to merge it (the tree was his for three weeks because I was away in mine), but it probably really just fell through the cracks. > Is this change wanted? Unless I get a "yes" from a maintainer, I'll > drop it. Yes, I think it's a good change. Kevin