From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54314)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nacc@linux.vnet.ibm.com>) id 1X207g-0006a8-JU
	for qemu-devel@nongnu.org; Tue, 01 Jul 2014 11:37:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nacc@linux.vnet.ibm.com>) id 1X207X-0003cL-3r
	for qemu-devel@nongnu.org; Tue, 01 Jul 2014 11:37:32 -0400
Received: from e9.ny.us.ibm.com ([32.97.182.139]:40934)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nacc@linux.vnet.ibm.com>) id 1X207W-0003cD-VU
	for qemu-devel@nongnu.org; Tue, 01 Jul 2014 11:37:23 -0400
Received: from /spool/local
	by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <nacc@linux.vnet.ibm.com>;
	Tue, 1 Jul 2014 11:37:22 -0400
Date: Tue, 1 Jul 2014 08:37:14 -0700
From: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
Message-ID: <20140701153713.GC15697@linux.vnet.ibm.com>
References: <20140630213456.GB15697@linux.vnet.ibm.com>
	<20140701152448.GR3222@otherpad.lan.raisama.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140701152448.GR3222@otherpad.lan.raisama.net>
Subject: Re: [Qemu-devel] [RFC PATCH v4] numa: enable sparse node numbering
	on ppc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Alexey Kardashevskiy <aik@ozlabs.ru>, Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Anton Blanchard <anton@samba.org>, David Rientjes <rientjes@google.com>, Igor Mammedov <imammedo@redhat.com>

On 01.07.2014 [12:24:48 -0300], Eduardo Habkost wrote:
> On Mon, Jun 30, 2014 at 02:34:56PM -0700, Nishanth Aravamudan wrote:
> [...]
> >              }
> > +	    assert(numa_info[i].present);
> >              numa_info[i].node_mem = ram_size - usedmem;
> >          }
> 
> Tab here.
> 
> >  
> [...]
> > +            for (i = 0, j = 0; i < max_cpus; i++) {
> > +		do {
> > +                    j = (j + 1) % (max_numa_nodeid);
> > +		} while (!numa_info[j].present);
> 
> Ditto.
> 
> (Those can be detected using checkpatch.pl).

Grr, sorry, I had been using checkpatch, but rushed this one. My
apologies!

> Other than that, the PC changes look good to me (I haven't reviewed the
> spapr.c changes). But I have an additional request: can you submit the
> nb_numa_nodes/num_numa_nodes rename as a separate patch, to make the
> other changes more visible and easier to review?

Yep, that makes sense.

Thanks,
Nish