From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2ExT-000138-Ct for qemu-devel@nongnu.org; Wed, 02 Jul 2014 03:28:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X2ExO-0007sO-B9 for qemu-devel@nongnu.org; Wed, 02 Jul 2014 03:27:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2ExO-0007rE-2Z for qemu-devel@nongnu.org; Wed, 02 Jul 2014 03:27:54 -0400 Date: Wed, 2 Jul 2014 09:29:54 +0300 From: "Michael S. Tsirkin" Message-ID: <20140702062954.GI3773@redhat.com> References: <1404259595-21680-1-git-send-email-tamlokveer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404259595-21680-1-git-send-email-tamlokveer@gmail.com> Subject: Re: [Qemu-devel] [PATCH] pci: assign devfn to pci_dev before calling pci_device_iommu_address_space() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Le Tan Cc: aik@ozlabs.ru, jan.kiszka@web.de, qemu-devel@nongnu.org On Wed, Jul 02, 2014 at 08:06:35AM +0800, Le Tan wrote: > In function do_pci_register_device() in file hw/pci/pci.c, move the assignment > of pci_dev->devfn to the position before the call to > pci_device_iommu_address_space(pci_dev) which will use the value of > pci_dev->devfn. Thanks, applied Fixes: 9eda7d373e9c691c070eddcbe3467b991f67f6bd pci: Introduce helper to retrieve a PCI device's DMA address space Cc: qemu-stable@nongnu.org > Signed-off-by: Le Tan > --- > hw/pci/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > index 17ed510..351d320 100644 > --- a/hw/pci/pci.c > +++ b/hw/pci/pci.c > @@ -827,6 +827,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus, > } > > pci_dev->bus = bus; > + pci_dev->devfn = devfn; > dma_as = pci_device_iommu_address_space(pci_dev); > > memory_region_init_alias(&pci_dev->bus_master_enable_region, > @@ -836,7 +837,6 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus, > address_space_init(&pci_dev->bus_master_as, &pci_dev->bus_master_enable_region, > name); > > - pci_dev->devfn = devfn; > pstrcpy(pci_dev->name, sizeof(pci_dev->name), name); > pci_dev->irq_state = 0; > pci_config_alloc(pci_dev); > -- > 1.7.9.5