* [Qemu-devel] [PATCH] pci: assign devfn to pci_dev before calling pci_device_iommu_address_space()
@ 2014-07-02 0:06 Le Tan
2014-07-02 6:29 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Le Tan @ 2014-07-02 0:06 UTC (permalink / raw)
To: qemu-devel; +Cc: jan.kiszka, Le Tan, mst
In function do_pci_register_device() in file hw/pci/pci.c, move the assignment
of pci_dev->devfn to the position before the call to
pci_device_iommu_address_space(pci_dev) which will use the value of
pci_dev->devfn.
Signed-off-by: Le Tan <tamlokveer@gmail.com>
---
hw/pci/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 17ed510..351d320 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -827,6 +827,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
}
pci_dev->bus = bus;
+ pci_dev->devfn = devfn;
dma_as = pci_device_iommu_address_space(pci_dev);
memory_region_init_alias(&pci_dev->bus_master_enable_region,
@@ -836,7 +837,6 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
address_space_init(&pci_dev->bus_master_as, &pci_dev->bus_master_enable_region,
name);
- pci_dev->devfn = devfn;
pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);
pci_dev->irq_state = 0;
pci_config_alloc(pci_dev);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] pci: assign devfn to pci_dev before calling pci_device_iommu_address_space()
2014-07-02 0:06 [Qemu-devel] [PATCH] pci: assign devfn to pci_dev before calling pci_device_iommu_address_space() Le Tan
@ 2014-07-02 6:29 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2014-07-02 6:29 UTC (permalink / raw)
To: Le Tan; +Cc: aik, jan.kiszka, qemu-devel
On Wed, Jul 02, 2014 at 08:06:35AM +0800, Le Tan wrote:
> In function do_pci_register_device() in file hw/pci/pci.c, move the assignment
> of pci_dev->devfn to the position before the call to
> pci_device_iommu_address_space(pci_dev) which will use the value of
> pci_dev->devfn.
Thanks, applied
Fixes: 9eda7d373e9c691c070eddcbe3467b991f67f6bd
pci: Introduce helper to retrieve a PCI device's DMA address space
Cc: qemu-stable@nongnu.org
> Signed-off-by: Le Tan <tamlokveer@gmail.com>
> ---
> hw/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index 17ed510..351d320 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -827,6 +827,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
> }
>
> pci_dev->bus = bus;
> + pci_dev->devfn = devfn;
> dma_as = pci_device_iommu_address_space(pci_dev);
>
> memory_region_init_alias(&pci_dev->bus_master_enable_region,
> @@ -836,7 +837,6 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
> address_space_init(&pci_dev->bus_master_as, &pci_dev->bus_master_enable_region,
> name);
>
> - pci_dev->devfn = devfn;
> pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);
> pci_dev->irq_state = 0;
> pci_config_alloc(pci_dev);
> --
> 1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-02 7:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-02 0:06 [Qemu-devel] [PATCH] pci: assign devfn to pci_dev before calling pci_device_iommu_address_space() Le Tan
2014-07-02 6:29 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).