From: Stefan Hajnoczi <stefanha@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.1 1/2] mirror: Fix qiov size for short requests
Date: Wed, 2 Jul 2014 10:13:44 +0200 [thread overview]
Message-ID: <20140702081344.GB4660@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1404226342-20174-2-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
On Tue, Jul 01, 2014 at 04:52:21PM +0200, Kevin Wolf wrote:
> When mirroring an image of a size that is not a multiple of the
> mirror job granularity, the last request would have the right nb_sectors
> argument, but a qiov that is rounded up to the next multiple of the
> granularity. Don't do this.
>
> This fixes a segfault that is caused by raw-posix being confused by this
> and allocating a buffer with request length, but operating on it with
> qiov length.
>
> Reported-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/mirror.c | 4 +++-
> tests/qemu-iotests/041 | 5 +++++
> tests/qemu-iotests/041.out | 4 ++--
> 3 files changed, 10 insertions(+), 3 deletions(-)
Applied Eric's suggestion.
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-07-02 8:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 14:52 [Qemu-devel] [PATCH for-2.1 0/2] Fix mirror segfault with unaligned size Kevin Wolf
2014-07-01 14:52 ` [Qemu-devel] [PATCH for-2.1 1/2] mirror: Fix qiov size for short requests Kevin Wolf
2014-07-01 16:52 ` Eric Blake
2014-07-01 21:31 ` Eric Blake
2014-07-02 8:50 ` Kevin Wolf
2014-07-02 8:13 ` Stefan Hajnoczi [this message]
2014-07-01 14:52 ` [Qemu-devel] [PATCH for-2.1 2/2] block: Assert qiov length matches request length Kevin Wolf
2014-07-01 15:16 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702081344.GB4660@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).