From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2Fuy-0002nq-Ab for qemu-devel@nongnu.org; Wed, 02 Jul 2014 04:29:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X2Fuu-0002iU-9u for qemu-devel@nongnu.org; Wed, 02 Jul 2014 04:29:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2345) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2Fut-0002iL-W2 for qemu-devel@nongnu.org; Wed, 02 Jul 2014 04:29:24 -0400 Date: Wed, 2 Jul 2014 10:29:13 +0200 From: Stefan Hajnoczi Message-ID: <20140702082913.GG4660@stefanha-thinkpad.redhat.com> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+1TulI7fc0PCHNy3" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH]Fix a error in mc146818rtc.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lb peace Cc: qemu-devel@nongnu.org, alex@alex.org.uk --+1TulI7fc0PCHNy3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 01, 2014 at 03:53:08AM +0800, Lb peace wrote: > If you use hwclock in guest os ,you will find the result of hwclock isn't > changed after changing host os's clock. > I find this issue is generated in this patch: >=20 > http://lists.gnu.org/archive/html/qemu-devel/2013-08/msg03353.html > Before this patch,the result will be changed if you change host's clock. > It makes use of the following codes in qemu-timer.c: > if (now < last) { > notifier_list_notify(&clock->reset_notifiers, &now); > } > It is useless if you register a QEMU_CLOCK_REALTIME's clock_reset_notifie= r, > --- Missing Signed-off-by: Your Name All patches in QEMU must have a Signed-off-by. For more details on the meaning of S-o-b, see: http://git.kernel.org/?p=3Dlinux/kernel/git/torvalds/linux-2.6.git;a=3Dblob= ;f=3DDocumentation/SubmittingPatches;h=3D689e2371095cc5dfea9927120009341f36= 9159aa;hb=3Df6f94e2ab1b33f0082ac22d71f66385a60d8157f#l297 > hw/timer/mc146818rtc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c > index df54546..821c27e 100644 > --- a/hw/timer/mc146818rtc.c > +++ b/hw/timer/mc146818rtc.c > @@ -879,7 +879,7 @@ static void rtc_realizefn(DeviceState *dev, Error > **errp) Please use git-send-email(1) to send patches. Or make sure there is no line-wrapping or other mangling of the patch. git-am(1) cannot apply your patch because of the line-wrapping. You can find the guidelines for submitting patches to QEMU here: http://qemu-project.org/Contribute/SubmitAPatch --+1TulI7fc0PCHNy3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTs8LZAAoJEJykq7OBq3PIdTkIAIz0y3vlNgZ+0O339DncgqYG gghdiDBNOP9Y8DMuJpoljBFlBrg6A68W83tcjh+L6gtyS4Y/SgVpL+e/ZNr7GOjr hJVax3Gr6UlddKUnYnBB1rcsE4LjsH07I1wptA5rNRIaj2wmybiALwxeF/IKrxXZ iSFJknH4yTi4fVRUpvF6LTl0Epf3GJ8MPmtofRPrWnXTtpWK/YfdnH6aJaTRGswS TkgthzuMLeM+yiTk/XEqHWCbsSTz8nBDWQmpecE79oQ+TztJ6U5T7H61d8LbLanv RQ9AeAEj8V3Tv+26WeKjCjU8JeDgAFNfo/iL7q8+VJQuG+V6KsWtPQnEM2oy8Ec= =/B2B -----END PGP SIGNATURE----- --+1TulI7fc0PCHNy3--