Re: [Qemu-devel] [PATCH for-2.1 1/2] mirror: Fix qiov size for short requests

[Kevin Wolf <kwolf@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

Am 01.07.2014 um 18:52 hat Eric Blake geschrieben:
> On 07/01/2014 08:52 AM, Kevin Wolf wrote:
> > When mirroring an image of a size that is not a multiple of the
> > mirror job granularity, the last request would have the right nb_sectors
> > argument, but a qiov that is rounded up to the next multiple of the
> > granularity. Don't do this.
> > 
> > This fixes a segfault that is caused by raw-posix being confused by this
> > and allocating a buffer with request length, but operating on it with
> > qiov length.
> > 
> > Reported-by: Eric Blake <eblake@redhat.com>
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> >  block/mirror.c             | 4 +++-
> >  tests/qemu-iotests/041     | 5 +++++
> >  tests/qemu-iotests/041.out | 4 ++--
> >  3 files changed, 10 insertions(+), 3 deletions(-)
> > 
> 
> > +++ b/tests/qemu-iotests/041
> > @@ -219,6 +219,11 @@ class TestSingleDriveZeroLength(TestSingleDrive):
> >      test_small_buffer2 = None
> >      test_large_cluster = None
> >  
> > +class TestSingleDriverUnalignedLength(TestSingleDrive):
> 
> s/Driver/Drive/ for consistency in the class name?

Yes, that was a typo. Thanks for catching it.

Kevin

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]