From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Jeff Cody <jcody@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PULL for-2.1 21/24] block: add QAPI command to allow live backing file change
Date: Wed, 2 Jul 2014 15:53:12 +0200 [thread overview]
Message-ID: <20140702135312.GJ5996@noname.str.redhat.com> (raw)
In-Reply-To: <53B331A1.2020707@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
Am 02.07.2014 um 00:09 hat Eric Blake geschrieben:
> On 07/01/2014 02:48 AM, Stefan Hajnoczi wrote:
> > From: Jeff Cody <jcody@redhat.com>
> >
> > This allows a user to make a live change to the backing file recorded in
> > an open image.
> >
>
> > +
> > + /* final sanity check */
> > + if (!bdrv_chain_contains(bs, image_bs)) {
> > + error_setg(errp, "'%s' and image file are not in the same chain",
> > + device);
> > + return;
> > + }
>
> Phooey - this is not bisectable, because bdrv_chain_contains was only
> introduced in 22/24. But it's already been pulled, so nothing we can do
> about it now.
We should probably start using git-compile-check before doing pull
requests. At least I haven't been doing this so far.
Kevin
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-07-02 13:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 8:48 [Qemu-devel] [PULL for-2.1 00/24] Block patches Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 01/24] qom: add object_property_add_alias() Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 02/24] virtio-blk: avoid qdev property definition duplication Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 03/24] dataplane: bail out on unsupported transport Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 04/24] virtio-blk: move x-data-plane qdev property to virtio-blk.h Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 05/24] qdev: add qdev_alias_all_properties() Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 06/24] virtio-blk: use aliases instead of duplicate qdev properties Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 07/24] virtio-blk: drop virtio_blk_set_conf() Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 08/24] virtio: fix virtio-blk child refcount in transports Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 09/24] virtio-blk: move qdev properties into virtio-blk.c Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 10/24] virtio-blk: replace x-iothread with iothread link property Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 11/24] qdev: drop iothread property type Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 12/24] virtio-blk: remove need for explicit x-data-plane=on option Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 13/24] qemu-img create: add 'nocow' option Stefan Hajnoczi
2014-07-02 3:10 ` Eric Blake
2014-07-02 4:34 ` Chun Yan Liu
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 14/24] iotests: Simplify qemu-iotests-quick.sh Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 15/24] iotests: Add qemu tests to quick group Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 16/24] iotests: Add more " Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 17/24] block: make 'top' argument to block-commit optional Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 18/24] block: simplify bdrv_find_base() and bdrv_find_overlay() Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 19/24] block/cow: Avoid use of uninitialized cow_bs in error path Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 20/24] qapi: Change back sector-count to sectors-count in quorum QAPI events Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 21/24] block: add QAPI command to allow live backing file change Stefan Hajnoczi
2014-07-01 22:09 ` Eric Blake
2014-07-02 13:53 ` Kevin Wolf [this message]
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 22/24] block: add helper function to determine if a BDS is in a chain Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 23/24] block: extend block-commit to accept a string for the backing file Stefan Hajnoczi
2014-07-01 8:48 ` [Qemu-devel] [PULL for-2.1 24/24] block: add backing-file option to block-stream Stefan Hajnoczi
2014-07-01 20:50 ` Eric Blake
2014-07-01 22:06 ` Eric Blake
2014-07-01 13:21 ` [Qemu-devel] [PULL for-2.1 00/24] Block patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702135312.GJ5996@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).