From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X40SH-0005lP-2A for qemu-devel@nongnu.org; Mon, 07 Jul 2014 00:23:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X40SA-0004Nk-Sy for qemu-devel@nongnu.org; Mon, 07 Jul 2014 00:23:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X40SA-0004Nf-K6 for qemu-devel@nongnu.org; Mon, 07 Jul 2014 00:22:58 -0400 Date: Mon, 7 Jul 2014 06:24:59 +0300 From: "Michael S. Tsirkin" Message-ID: <20140707032459.GC4589@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH V2 for 2.1 0/3] bug fixs for memory backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Yasunori Goto , Paolo Bonzini , qemu-devel@nongnu.org, Igor Mammedov On Mon, Jul 07, 2014 at 10:58:05AM +0800, Hu Tao wrote: > This series includes three patches to fix bugs of memory backend. Patch > 1 prepares for next patches, patch 2 and patch 3 fix two bugs > respectively, see each patch for the bugs and how to reproduce them. > > changes to v1: > > - split patch 1 in v1 into 2 patches > - don't rely on ram_block_add to return -1 > - error message tweak in file_ram_alloc > - add error messages reported by qemu to commit message of patch 3 > > Hu Tao (3): > memory: rename memory_region_init_ram() and > memory_region_init_ram_ptr() > memory: add errp parameter to memory_region_init_ram() and > memory_region_init_ram_ptr() > exec: improve error handling and reporting in file_ram_alloc() and > gethugepagesize() I fixed up some minor issues and applied this, thanks. > backends/hostmem-ram.c | 2 +- > exec.c | 51 ++++++++++++++++++++++++++++--------------- > hw/block/pflash_cfi01.c | 5 ++++- > hw/block/pflash_cfi02.c | 5 ++++- > hw/core/loader.c | 2 +- > hw/display/vga.c | 2 +- > hw/display/vmware_vga.c | 3 ++- > hw/i386/kvm/pci-assign.c | 9 ++++---- > hw/i386/pc.c | 2 +- > hw/i386/pc_sysfw.c | 4 ++-- > hw/misc/ivshmem.c | 9 ++++---- > hw/misc/vfio.c | 3 ++- > hw/pci/pci.c | 2 +- > include/exec/memory.h | 43 +++++++++++++++++++++++++++++++++--- > include/exec/ram_addr.h | 4 ++-- > memory.c | 57 +++++++++++++++++++++++++++++++++++++++++++----- > numa.c | 4 ++-- > 17 files changed, 158 insertions(+), 49 deletions(-) > > -- > 1.9.3