From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X44DG-0003wz-Bu for qemu-devel@nongnu.org; Mon, 07 Jul 2014 04:23:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X44D9-0002Ns-Hx for qemu-devel@nongnu.org; Mon, 07 Jul 2014 04:23:50 -0400 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:52567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X44D9-0002No-Af for qemu-devel@nongnu.org; Mon, 07 Jul 2014 04:23:43 -0400 Received: by mail-wi0-f169.google.com with SMTP id hi2so14531697wib.2 for ; Mon, 07 Jul 2014 01:23:42 -0700 (PDT) Date: Mon, 7 Jul 2014 10:23:38 +0200 From: Stefan Hajnoczi Message-ID: <20140707082338.GD7963@stefanha-thinkpad.redhat.com> References: <1404375987-29810-1-git-send-email-tamlokveer@gmail.com> <20140703082852.GC20580@redhat.com> <20140706061538.GA7425@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WChQLJJJfbwij+9x" Content-Disposition: inline In-Reply-To: <20140706061538.GA7425@redhat.com> Subject: Re: [Qemu-devel] for-2.1 (was Re: [PATCH] ahci: map memory via device's address space instead of address_space_memory) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: kwolf@redhat.com, peter.maydell@linaro.org, Le Tan , qemu-devel@nongnu.org, jan.kiszka@web.de, stefanha@redhat.com, pbonzini@redhat.com, afaerber@suse.de --WChQLJJJfbwij+9x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 06, 2014 at 09:15:38AM +0300, Michael S. Tsirkin wrote: > On Thu, Jul 03, 2014 at 11:28:52AM +0300, Michael S. Tsirkin wrote: > > On Thu, Jul 03, 2014 at 04:26:27PM +0800, Le Tan wrote: > > > In map_page() in hw/ide/ahci.c, replace cpu_physical_memory_map() and > > > cpu_physical_memory_unmap() with dma_memory_map() and dma_memory_unma= p(), > > > because ahci devices should not access memory directly but via their = address > > > space. Add an AddressSpace parameter to map_page(). In order to call > > > map_page(), we should pass the AHCIState.as as the AddressSpace argum= ent. > > >=20 > > > Signed-off-by: Le Tan > >=20 > > Makes sense > > Reviewed-by: Michael S. Tsirkin > >=20 >=20 > Stefan, Kevin, you are going to pick this one? Done. Stefan --WChQLJJJfbwij+9x Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTulkKAAoJEJykq7OBq3PI1YEH/0GPxyflSlMI4r+vLDK3R9rZ nCGD9myjxximZ6Kd2H5F83YyWzNWB6jMLom07vb+LuecTjJOINplJWmq90zQOAgC uOJ2VCPV4mzzlhYryCKULyxc4TOvZ76/2PDEhF0hYwmAIPe5YZQNRQHIf+COzNL3 RYV9TgLCSCZ74tfKGSOACBmSaZVwYR5pVhhhX6AlLXVZZlIGdSlVV/ADGWGMu3HE PhVqy9XbUGPIRPQ21pAGSmJ5bBLv5+M//eN5v6Kpeu7HcvkFHkoB6/TyaLSLLaBP GwAICBcu65H72wJ/xZK3OC7WTSqT5jy6IRanKNP9ejhKP+phy2ZFK/LIRy5Hbgs= =xrEV -----END PGP SIGNATURE----- --WChQLJJJfbwij+9x--