From: Stefan Hajnoczi <stefanha@gmail.com>
To: Cole Robinson <crobinso@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] bootindex dropped from -device virtio-blk, ? output, upsets libvirt
Date: Mon, 7 Jul 2014 11:06:50 +0200 [thread overview]
Message-ID: <20140707090650.GH7963@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <53B6F6CD.4060200@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
On Fri, Jul 04, 2014 at 02:47:41PM -0400, Cole Robinson wrote:
> qemu-2.1-rc0 upsets some of libvirt's qemu feature introspection, the example
> I hit is with bootindex support. qemu -device virtio-blk,? no longer lists the
> bootindex= property, so libvirt thinks that qemu doesn't support it, and fails
> to launch a VM with per-device boot order configuration.
>
> The qemu culprit is:
>
> commit caffdac363801cd2cf2bf01ad013a8c1e1e43800
> Author: Stefan Hajnoczi <stefanha@redhat.com>
> Date: Wed Jun 18 17:58:33 2014 +0800
>
> virtio-blk: use aliases instead of duplicate qdev properties
>
> These alias properties aren't printed in qdev-monitor.c:qdev_device_help. In
> fact I'm not sure if aliases are even accessible in that function, since the
> they are only registered at instance init time, and I don't think any device
> has actually been initialized when qdev_device_help is called. That's my
> reading anyways.
>
> Thoughts?
I will send a fix.
Thanks,
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-07-07 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 18:47 [Qemu-devel] bootindex dropped from -device virtio-blk, ? output, upsets libvirt Cole Robinson
2014-07-07 9:06 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707090650.GH7963@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=crobinso@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).