From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X44t7-0005WS-7r for qemu-devel@nongnu.org; Mon, 07 Jul 2014 05:07:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X44sy-0006Xt-6f for qemu-devel@nongnu.org; Mon, 07 Jul 2014 05:07:05 -0400 Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:49166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X44sx-0006W0-VZ for qemu-devel@nongnu.org; Mon, 07 Jul 2014 05:06:56 -0400 Received: by mail-we0-f176.google.com with SMTP id u56so4028904wes.35 for ; Mon, 07 Jul 2014 02:06:53 -0700 (PDT) Date: Mon, 7 Jul 2014 11:06:50 +0200 From: Stefan Hajnoczi Message-ID: <20140707090650.GH7963@stefanha-thinkpad.redhat.com> References: <53B6F6CD.4060200@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KscVNZbUup0vZz0f" Content-Disposition: inline In-Reply-To: <53B6F6CD.4060200@redhat.com> Subject: Re: [Qemu-devel] bootindex dropped from -device virtio-blk, ? output, upsets libvirt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson Cc: qemu-devel , Stefan Hajnoczi --KscVNZbUup0vZz0f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 04, 2014 at 02:47:41PM -0400, Cole Robinson wrote: > qemu-2.1-rc0 upsets some of libvirt's qemu feature introspection, the exa= mple > I hit is with bootindex support. qemu -device virtio-blk,? no longer list= s the > bootindex=3D property, so libvirt thinks that qemu doesn't support it, an= d fails > to launch a VM with per-device boot order configuration. >=20 > The qemu culprit is: >=20 > commit caffdac363801cd2cf2bf01ad013a8c1e1e43800 > Author: Stefan Hajnoczi > Date: Wed Jun 18 17:58:33 2014 +0800 >=20 > virtio-blk: use aliases instead of duplicate qdev properties >=20 > These alias properties aren't printed in qdev-monitor.c:qdev_device_help.= In > fact I'm not sure if aliases are even accessible in that function, since = the > they are only registered at instance init time, and I don't think any dev= ice > has actually been initialized when qdev_device_help is called. That's my > reading anyways. >=20 > Thoughts? I will send a fix. Thanks, Stefan --KscVNZbUup0vZz0f Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTumMqAAoJEJykq7OBq3PIq3wIAIgOc9ytvRu9emhOGNKQD52k gJtCPRF9DYMuVVL/hRes6xlLbg8DzROzGjcvKP/qWIs30YhP2ZI3xb+2CV/IMUyG Qhau0gwnoMtkeoT/SzCOdEk35r226Qja8CYQ1PI7dDlTuwIHuC7kB3ZS1ZMSzkYG V93UuVuePYZ9XF7QqkYvpsXMcEIrBsSRUNRiroClm+AjOaqm9YD1aHjxnO/0vlkC PJ1Jri2cjhLN9VGpOMnaNL56wyjuvu8v4xnRTGU87224HNGo0DrbEqWu1p/uojyw rJYjjYitUg8avcAlZL5Zr1L1L9prrf5fwEvdY9IntmsT4cGw9kIm7Pd9NBBXAWY= =sY3n -----END PGP SIGNATURE----- --KscVNZbUup0vZz0f--